From: Dale Farnsworth <dale@farnsworth.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 1/9 v2] powerpc: change FDT compatible prefix to mrvl
Date: Mon, 7 Apr 2008 14:53:00 -0700 [thread overview]
Message-ID: <20080407215300.GA23434@farnsworth.org> (raw)
In-Reply-To: <7b4fa46820f05cd088680ed3eb521ad6@kernel.crashing.org>
On Mon, Apr 07, 2008 at 10:49:40PM +0200, Segher Boessenkool wrote:
>> Follow the convention that compatible names are prefixed by the
>> vendor's stock ticker symbol. For Marvell Technology Group Ltd.,
>> that's MRVL.
>
>> - compatible = "marvell,mv64x60";
>> + compatible = "mrvl,mv64x60";
>
> NAK.
>
> Either use the stock ticker, in UPPER CASE, or use a nice
> descriptive name. The lower case space is "free for all",
> using shortened names (like "mrvl") there only increases
> the chances of collisions.
[Oops, I forgot to copy the list on my reply to Segher.
Segher, sorry for the repeat.]
Frankly Segher, it doesn't matter to me. However, NONE of the
existing DTS files use upper-case stock ticker. I see no reason
to deviate from the existing convention (even if that convention
doesn't follow the previous convention of using upper-case).
Since it seems that the convention for compatible property
prefixes hasn't been decided yet, maybe it would be best for
me to back out this patch and redo those that follow.
I'll do that and repost the series.
-Dale
next prev parent reply other threads:[~2008-04-07 21:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 18:32 [PATCH 0/9 v2] powerpc: mv64x60 and prpmc2800 DTS cleanups Dale Farnsworth
2008-04-07 18:38 ` [PATCH 1/9 v2] powerpc: change FDT compatible prefix to mrvl Dale Farnsworth
2008-04-07 20:49 ` Segher Boessenkool
2008-04-07 21:53 ` Dale Farnsworth [this message]
[not found] ` <20080407210314.GA21993@farnsworth.org>
2008-04-08 6:34 ` Segher Boessenkool
2008-04-07 18:46 ` [PATCH 2/9 v2] powerpc: prpmc2800: convert DTS to v1 and add labels Dale Farnsworth
2008-04-07 18:47 ` [PATCH 3/9 v2] powerpc: fix frequencies in prpmc2800.dts Dale Farnsworth
2008-04-07 18:49 ` [PATCH 4/9 v2] powerpc: mv64x60: Fix FDT compatible names: mv64x60 => mv64360 Dale Farnsworth
2008-04-07 18:50 ` [PATCH 5/9 v2] powerpc: mv64x60: remove device tree absolute path references Dale Farnsworth
2008-04-07 18:51 ` [PATCH 6/9 v2] powerpc: prpmc2800: clean up dts properties Dale Farnsworth
2008-04-07 18:53 ` [PATCH 7/9 v2] powerpc: mv643xx_eth: prepare to support multiple silicon blocks Dale Farnsworth
2008-04-07 18:54 ` [PATCH 8/9 v2] powerpc: Document the mv64x60 device tree bindings Dale Farnsworth
2008-04-07 18:55 ` [PATCH 9/9 v2] powerpc: prpmc2800 needs a dtbImage Dale Farnsworth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407215300.GA23434@farnsworth.org \
--to=dale@farnsworth.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).