From: Benjamin Herrenschmidt <benh@ozlabs.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth
Date: Wed, 09 Apr 2008 17:21:34 +1000 [thread overview]
Message-ID: <20080409072230.C861EDDED0@ozlabs.org> (raw)
The iSeries veth driver uses an on-stack struct completion that
it initializes using the COMPLETION_INITIALIZER instead of
COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
lockdep.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
drivers/net/iseries_veth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-work.orig/drivers/net/iseries_veth.c 2008-04-09 13:55:24.000000000 +1000
+++ linux-work/drivers/net/iseries_veth.c 2008-04-09 13:55:48.000000000 +1000
@@ -308,7 +308,8 @@ static void veth_complete_allocation(voi
static int veth_allocate_events(HvLpIndex rlp, int number)
{
- struct veth_allocation vc = { COMPLETION_INITIALIZER(vc.c), 0 };
+ struct veth_allocation vc =
+ { COMPLETION_INITIALIZER_ONSTACK(vc.c), 0 };
mf_allocate_lp_events(rlp, HvLpEvent_Type_VirtualLan,
sizeof(struct veth_lpevent), number,
next reply other threads:[~2008-04-09 7:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-09 7:21 Benjamin Herrenschmidt [this message]
2008-04-09 8:36 ` [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth Christoph Hellwig
2008-04-09 21:03 ` Benjamin Herrenschmidt
2008-04-10 10:56 ` Christoph Hellwig
2008-04-10 12:21 ` Benjamin Herrenschmidt
2008-04-09 8:55 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080409072230.C861EDDED0@ozlabs.org \
--to=benh@ozlabs.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).