[PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[Benjamin Herrenschmidt]

The iSeries veth driver uses an on-stack struct completion that
it initializes using the COMPLETION_INITIALIZER instead of
COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
lockdep.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

 drivers/net/iseries_veth.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-work.orig/drivers/net/iseries_veth.c	2008-04-09 13:55:24.000000000 +1000
+++ linux-work/drivers/net/iseries_veth.c	2008-04-09 13:55:48.000000000 +1000
@@ -308,7 +308,8 @@ static void veth_complete_allocation(voi
 
 static int veth_allocate_events(HvLpIndex rlp, int number)
 {
-	struct veth_allocation vc = { COMPLETION_INITIALIZER(vc.c), 0 };
+	struct veth_allocation vc =
+		{ COMPLETION_INITIALIZER_ONSTACK(vc.c), 0 };
 
 	mf_allocate_lp_events(rlp, HvLpEvent_Type_VirtualLan,
 			    sizeof(struct veth_lpevent), number,

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[Christoph Hellwig]

On Wed, Apr 09, 2008 at 05:21:34PM +1000, Benjamin Herrenschmidt wrote:
> The iSeries veth driver uses an on-stack struct completion that
> it initializes using the COMPLETION_INITIALIZER instead of
> COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
> lockdep.

should probably go in ASAP independent of the lockdep series.

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Wed, 09 Apr 2008 17:21:34 +1000 Benjamin Herrenschmidt <benh@ozlabs.org> wrote:
>
> The iSeries veth driver uses an on-stack struct completion that
> it initializes using the COMPLETION_INITIALIZER instead of
> COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
> lockdep.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[Benjamin Herrenschmidt]

On Wed, 2008-04-09 at 10:36 +0200, Christoph Hellwig wrote:
> On Wed, Apr 09, 2008 at 05:21:34PM +1000, Benjamin Herrenschmidt wrote:
> > The iSeries veth driver uses an on-stack struct completion that
> > it initializes using the COMPLETION_INITIALIZER instead of
> > COMPLETION_INITIALIZER_ONSTACK macro, causing problems with
> > lockdep.
> 
> should probably go in ASAP independent of the lockdep series.

I don't think there's any difference between the _ONSTACK variant
and the normal one without lockdep, is there ?

Cheers,
Ben.

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[Christoph Hellwig]

On Thu, Apr 10, 2008 at 07:03:22AM +1000, Benjamin Herrenschmidt wrote:
> I don't think there's any difference between the _ONSTACK variant
> and the normal one without lockdep, is there ?

No there's not.  Thus it's a guaranteed no-op and can easily go in.

Re: [PATCH 5/6] [POWERPC] properly declare onstack completion in iseries veth

[Benjamin Herrenschmidt]

On Thu, 2008-04-10 at 12:56 +0200, Christoph Hellwig wrote:
> On Thu, Apr 10, 2008 at 07:03:22AM +1000, Benjamin Herrenschmidt wrote:
> > I don't think there's any difference between the _ONSTACK variant
> > and the normal one without lockdep, is there ?
> 
> No there's not.  Thus it's a guaranteed no-op and can easily go in.

Heh, I won't argue either way :-) It's Paul's call at this stage.

Cheers,
Ben.