From: Sean MacLennan <smaclennan@pikatech.com>
To: jwboyer@linux.vnet.ibm.com
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/5] Boot code
Date: Sat, 12 Apr 2008 22:06:46 -0400 [thread overview]
Message-ID: <20080412220646.3d8ee450@lappy.seanm.ca> (raw)
In-Reply-To: <1208047783.5869.35.camel@vader.jdub.homelinux.org>
On Sat, 12 Apr 2008 19:49:43 -0500
Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:
> On Sat, 2008-04-12 at 14:01 -0400, Sean MacLennan wrote:
> > Signed-off-by: Sean MacLennan <smaclennan@pikatech.com>
> >
>
> This patch is word wrapped.
Yes, sorry about that. I have been trying out a new mail client and I
pasted the text wrong :( I caught it in the other patches though,
so they should be good.
> > + char name[40];
> > + u32 v[2];
> > +
> > + sprintf(name, "/plb/opb/ebc/nor_flash@0,0/partition@%x",
> > from);
>
> Unless I can't count (which could very well be the case), you have a
> buffer overflow here. The fixed string is 37 characters, and the
> values you are passing in for "from" will extend the string past the
> 40 bytes you have allocated for "name".
No, you are right. Good catch. I will update that.
Cheers,
Sean
next prev parent reply other threads:[~2008-04-13 2:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 17:48 Warp patches for 2.6.26 Sean MacLennan
2008-04-12 18:01 ` [PATCH 1/5] Boot code Sean MacLennan
2008-04-13 0:49 ` Josh Boyer
2008-04-13 2:06 ` Sean MacLennan [this message]
2008-04-12 18:03 ` PATCH 2/5] Platform code Sean MacLennan
2008-04-13 3:15 ` Sean MacLennan
2008-04-14 16:00 ` David Woodhouse
2008-04-12 18:09 ` [PATCH 3/5] Defconfig Sean MacLennan
2008-04-12 18:10 ` [PATCH 4/5] LED driver Sean MacLennan
2008-04-13 0:41 ` Josh Boyer
2008-04-17 17:32 ` Sean MacLennan
2008-04-13 12:28 ` Peter Korsgaard
2008-04-13 16:51 ` Sean MacLennan
2008-04-13 17:34 ` Peter Korsgaard
2008-04-13 17:51 ` Sean MacLennan
2008-04-12 18:11 ` [PATCH 5/5] WDT driver Sean MacLennan
2008-04-13 0:40 ` Josh Boyer
2008-04-14 8:33 ` Laurent Pinchart
2008-04-14 15:40 ` Sean MacLennan
2008-04-13 0:44 ` Warp patches for 2.6.26 Stephen Rothwell
2008-04-13 0:50 ` Josh Boyer
2008-04-13 1:55 ` Sean MacLennan
2008-04-13 2:09 ` Grant Likely
2008-04-13 2:38 ` Sean MacLennan
2008-04-13 3:13 ` Dale Farnsworth
2008-04-17 15:50 ` Sean MacLennan
2008-04-17 16:08 ` Dale Farnsworth
2008-04-17 17:26 ` Sean MacLennan
2008-04-17 18:11 ` Dale Farnsworth
2008-04-13 1:11 ` Paul Mackerras
2008-04-13 2:24 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080412220646.3d8ee450@lappy.seanm.ca \
--to=smaclennan@pikatech.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).