From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fsl_soc: Factor fsl_get_sys_freq() out of the wdt and spi inits.
Date: Wed, 16 Apr 2008 18:02:10 +0400 [thread overview]
Message-ID: <20080416140210.GA15529@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <48051FBA.1000801@freescale.com>
On Tue, Apr 15, 2008 at 04:35:54PM -0500, Scott Wood wrote:
> Anton Vorontsov wrote:
>>> +u32 fsl_get_sys_freq(void)
>>> +{
>>> + struct device_node *soc;
>>> + const u32 *prop;
>>> + int size;
>>> +
>>> + if (sysfreq != -1)
>>> + return sysfreq;
>>> +
>>> + soc = of_find_node_by_type(NULL, "soc");
>>> + if (!soc)
>>> + return -1;
>>
>> Um.. can we finally decide on compatible for the soc nodes,
>> and add there compatible matching from the start?
>
> This is just a code reorganization; any change in what we match on
> should be a separate patch.
Yes, it makes sense of course. Just wanted to get rid of the device_type
asap, because I'm going to submit mpc836x_rdk board, and I'd preferred to
submit it w/o device_type = "soc"... Oh well, ok.. later.
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-04-16 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 18:52 [PATCH] fsl_soc: Factor fsl_get_sys_freq() out of the wdt and spi inits Scott Wood
2008-04-15 21:32 ` Anton Vorontsov
2008-04-15 21:35 ` Scott Wood
2008-04-15 21:52 ` Kumar Gala
2008-04-16 14:02 ` Anton Vorontsov [this message]
2008-04-15 23:20 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080416140210.GA15529@polina.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).