linux-next: 4xx build failure

linux-next: 4xx build failure

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1211 bytes --]

Hi Josh,

Today's linux-next build (powerpc allyesconfig) failed like this:

drivers/net/ibm_newemac/core.c: In function ‘emac_rx_clk_tx’:
drivers/net/ibm_newemac/core.c:146: error: implicit declaration of function ‘dcri_clrset’
drivers/net/ibm_newemac/core.c:146: error: ‘SDR0’ undeclared (first use in this function)
drivers/net/ibm_newemac/core.c:146: error: (Each undeclared identifier is reported only once
drivers/net/ibm_newemac/core.c:146: error: for each function it appears in.)
drivers/net/ibm_newemac/core.c: In function ‘emac_rx_clk_default’:
drivers/net/ibm_newemac/core.c:152: error: ‘SDR0’ undeclared (first use in this function)
drivers/net/ibm_newemac/core.c: In function ‘emac_init_phy’:
drivers/net/ibm_newemac/core.c:2361: error: ‘SDR0’ undeclared (first use in this function)

I have reverted commit 863a1175e22cb108f596a5aa55b1e535a77e7cce
("[POWERPC] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround")
and commit 4b2d72f5035764cd2e89f5a13ab35c11a27c557b ("[POWERPC]
ibm_newemac: PowerPC 440GX EMAC PHY clock workaround").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: linux-next: 4xx build failure

[Josh Boyer]

On Wed, 16 Apr 2008 19:42:27 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Josh,
>=20
> Today's linux-next build (powerpc allyesconfig) failed like this:
>=20
> drivers/net/ibm_newemac/core.c: In function =E2=80=98emac_rx_clk_tx=E2=80=
=99:
> drivers/net/ibm_newemac/core.c:146: error: implicit declaration of functi=
on =E2=80=98dcri_clrset=E2=80=99
> drivers/net/ibm_newemac/core.c:146: error: =E2=80=98SDR0=E2=80=99 undecla=
red (first use in this function)
> drivers/net/ibm_newemac/core.c:146: error: (Each undeclared identifier is=
 reported only once
> drivers/net/ibm_newemac/core.c:146: error: for each function it appears i=
n.)
> drivers/net/ibm_newemac/core.c: In function =E2=80=98emac_rx_clk_default=
=E2=80=99:
> drivers/net/ibm_newemac/core.c:152: error: =E2=80=98SDR0=E2=80=99 undecla=
red (first use in this function)
> drivers/net/ibm_newemac/core.c: In function =E2=80=98emac_init_phy=E2=80=
=99:
> drivers/net/ibm_newemac/core.c:2361: error: =E2=80=98SDR0=E2=80=99 undecl=
ared (first use in this function)
>=20
> I have reverted commit 863a1175e22cb108f596a5aa55b1e535a77e7cce
> ("[POWERPC] ibm_newemac: PowerPC 440EP/440GR EMAC PHY clock workaround")
> and commit 4b2d72f5035764cd2e89f5a13ab35c11a27c557b ("[POWERPC]
> ibm_newemac: PowerPC 440GX EMAC PHY clock workaround").

Grr.  Yes, that's probably the right solution for now.  I had forgotten
about Axon.

Sorry for the trouble.  I'll revert those commits locally and repush.

josh

Re: linux-next: 4xx build failure

[Benjamin Herrenschmidt]

> Grr.  Yes, that's probably the right solution for now.  I had forgotten
> about Axon.
> 
> Sorry for the trouble.  I'll revert those commits locally and repush.

MMIO is not only Axon.. .some Xilinx stuff too. We should have a proper
implementation of the dcri stuff for MMIO.

Ben.

Re: linux-next: 4xx build failure

[Josh Boyer]

On Wed, 16 Apr 2008 22:51:22 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:

> 
> > Grr.  Yes, that's probably the right solution for now.  I had forgotten
> > about Axon.
> > 
> > Sorry for the trouble.  I'll revert those commits locally and repush.
> 
> MMIO is not only Axon.. .some Xilinx stuff too. We should have a proper

Yes.  But Axon is the only one in-tree that uses it at the moment.

> implementation of the dcri stuff for MMIO.

Yes, of course.  Though neither you or I thought of that when we acked
the patch :).

josh