linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sean MacLennan <seanm@seanm.ca>
To: "Dale Farnsworth" <dale@farnsworth.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Warp patches for 2.6.26
Date: Thu, 17 Apr 2008 11:50:45 -0400	[thread overview]
Message-ID: <20080417115045.7e4e6b1e@lappy.seanm.ca> (raw)
In-Reply-To: <E1Jksea-0001ba-DL@xyzzy.farnsworth.org>

On Sat, 12 Apr 2008 20:13:16 -0700
"Dale Farnsworth" <dale@farnsworth.org> wrote:

> Each patch needs to be standalone.  you need to add a header
> describing what the patch is intended to accomplish.  Being more
> descriptive is better than less.  Also, as Stephen said, make sure
> that the subject of each email containing a patch is descriptive and
> reasonably unique within the entire kernel.

Splitting up the patches would be very error prone. I would have to
basically do all the editing by hand.

I also think I am not being clear enough. Basically what is currently
in the mainline is platform code for a Rev A board with minimal FPGA
functionality, since that is what we had at the time.

These patches, I should probably merge them into one patch, bring the
platform code up to a Rev B board with a more complete FPGA load. (I
say more complete because FPGA loads are never complete ;)

These patches only affect the Warp. Ignoring the LED and WDT patches,
you have to have all the changes to get a working Rev B. You can't just
put in the DTM changes or just put in the NAND changes.

I listed 8 changes, but three are for NAND, and four are for DTM. I
could compress them down:

Updated platform code to support Rev B boards.
  * Switched from 64M NOR/64M NAND to 4M NOR/256M NAND.
  * Fully functional DTM.
  * Added POST information.
  * Removed LED function, moved to new LED driver.

Now, the POST function and the removed LED function could be separate
patches I guess, but it hardly seems worth it. The LED function was
never used except in temporary debug code.

> For example, instead of "WDT driver", as a minimum something like:
> "[POWERPC] warp: Add WDT driver".

Ok, that I can do.

Cheers,
   Sean

  reply	other threads:[~2008-04-17 15:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-12 17:48 Warp patches for 2.6.26 Sean MacLennan
2008-04-12 18:01 ` [PATCH 1/5] Boot code Sean MacLennan
2008-04-13  0:49   ` Josh Boyer
2008-04-13  2:06     ` Sean MacLennan
2008-04-12 18:03 ` PATCH 2/5] Platform code Sean MacLennan
2008-04-13  3:15   ` Sean MacLennan
2008-04-14 16:00   ` David Woodhouse
2008-04-12 18:09 ` [PATCH 3/5] Defconfig Sean MacLennan
2008-04-12 18:10 ` [PATCH 4/5] LED driver Sean MacLennan
2008-04-13  0:41   ` Josh Boyer
2008-04-17 17:32     ` Sean MacLennan
2008-04-13 12:28   ` Peter Korsgaard
2008-04-13 16:51     ` Sean MacLennan
2008-04-13 17:34       ` Peter Korsgaard
2008-04-13 17:51         ` Sean MacLennan
2008-04-12 18:11 ` [PATCH 5/5] WDT driver Sean MacLennan
2008-04-13  0:40   ` Josh Boyer
2008-04-14  8:33   ` Laurent Pinchart
2008-04-14 15:40     ` Sean MacLennan
2008-04-13  0:44 ` Warp patches for 2.6.26 Stephen Rothwell
2008-04-13  0:50   ` Josh Boyer
2008-04-13  1:55   ` Sean MacLennan
2008-04-13  2:09     ` Grant Likely
2008-04-13  2:38       ` Sean MacLennan
2008-04-13  3:13         ` Dale Farnsworth
2008-04-17 15:50           ` Sean MacLennan [this message]
2008-04-17 16:08             ` Dale Farnsworth
2008-04-17 17:26               ` Sean MacLennan
2008-04-17 18:11                 ` Dale Farnsworth
2008-04-13  1:11 ` Paul Mackerras
2008-04-13  2:24 ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080417115045.7e4e6b1e@lappy.seanm.ca \
    --to=seanm@seanm.ca \
    --cc=dale@farnsworth.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).