From: Sean MacLennan <seanm@seanm.ca>
To: "Dale Farnsworth" <dale@farnsworth.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Warp patches for 2.6.26
Date: Thu, 17 Apr 2008 13:26:23 -0400 [thread overview]
Message-ID: <20080417132623.58f8dba7@lappy.seanm.ca> (raw)
In-Reply-To: <20080417160804.GA696@farnsworth.org>
On Thu, 17 Apr 2008 09:08:04 -0700
"Dale Farnsworth" <dale@farnsworth.org> wrote:
> I didn't suggest splitting the patches or further modification of the
> patches themselves. What I found lacking were the patch descriptions.
> You need to describe in each patch (commit) commentary exactly what
> the patch is intended to accomplish, and the rationale behind it.
Ok, that makes more sense to me. Sorry that I read that wrong :(
One last question.... would the warp_defconfig be considered part of
the platform code? I think one of the problems was I split up the
patches when really they all go together (again ignoring led and wdt).
But I am not sure if the defconfig really goes with the platform code.
Cheers,
Sean
next prev parent reply other threads:[~2008-04-17 17:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 17:48 Warp patches for 2.6.26 Sean MacLennan
2008-04-12 18:01 ` [PATCH 1/5] Boot code Sean MacLennan
2008-04-13 0:49 ` Josh Boyer
2008-04-13 2:06 ` Sean MacLennan
2008-04-12 18:03 ` PATCH 2/5] Platform code Sean MacLennan
2008-04-13 3:15 ` Sean MacLennan
2008-04-14 16:00 ` David Woodhouse
2008-04-12 18:09 ` [PATCH 3/5] Defconfig Sean MacLennan
2008-04-12 18:10 ` [PATCH 4/5] LED driver Sean MacLennan
2008-04-13 0:41 ` Josh Boyer
2008-04-17 17:32 ` Sean MacLennan
2008-04-13 12:28 ` Peter Korsgaard
2008-04-13 16:51 ` Sean MacLennan
2008-04-13 17:34 ` Peter Korsgaard
2008-04-13 17:51 ` Sean MacLennan
2008-04-12 18:11 ` [PATCH 5/5] WDT driver Sean MacLennan
2008-04-13 0:40 ` Josh Boyer
2008-04-14 8:33 ` Laurent Pinchart
2008-04-14 15:40 ` Sean MacLennan
2008-04-13 0:44 ` Warp patches for 2.6.26 Stephen Rothwell
2008-04-13 0:50 ` Josh Boyer
2008-04-13 1:55 ` Sean MacLennan
2008-04-13 2:09 ` Grant Likely
2008-04-13 2:38 ` Sean MacLennan
2008-04-13 3:13 ` Dale Farnsworth
2008-04-17 15:50 ` Sean MacLennan
2008-04-17 16:08 ` Dale Farnsworth
2008-04-17 17:26 ` Sean MacLennan [this message]
2008-04-17 18:11 ` Dale Farnsworth
2008-04-13 1:11 ` Paul Mackerras
2008-04-13 2:24 ` Josh Boyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080417132623.58f8dba7@lappy.seanm.ca \
--to=seanm@seanm.ca \
--cc=dale@farnsworth.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).