* [PATCH 3/3] Use __weak macro for smp_setup_processor_id
@ 2008-04-18 6:56 Benjamin Herrenschmidt
2008-04-18 7:07 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2008-04-18 6:56 UTC (permalink / raw)
To: Andrew Morton, Paul Mackerras; +Cc: Linux-Arch, linuxppc-dev, linux-kernel
Use the __weak macro instead of the longer __attribute__ ((weak)) form
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
--
init/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
+++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
@@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
cpu_set(cpu, cpu_possible_map);
}
-void __init __attribute__((weak)) smp_setup_processor_id(void)
+void __init __weak smp_setup_processor_id(void)
{
}
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
2008-04-18 6:56 [PATCH 3/3] Use __weak macro for smp_setup_processor_id Benjamin Herrenschmidt
@ 2008-04-18 7:07 ` Andrew Morton
2008-04-18 8:19 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2008-04-18 7:07 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: Linux-Arch, linuxppc-dev, Paul Mackerras, linux-kernel
On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> Use the __weak macro instead of the longer __attribute__ ((weak)) form
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> --
>
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
> +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
> @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
> cpu_set(cpu, cpu_possible_map);
> }
>
> -void __init __attribute__((weak)) smp_setup_processor_id(void)
> +void __init __weak smp_setup_processor_id(void)
> {
> }
ack on all three. Please fold #3 into #1 and add both to git-powerpc.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
2008-04-18 7:07 ` Andrew Morton
@ 2008-04-18 8:19 ` Benjamin Herrenschmidt
2008-04-18 8:38 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2008-04-18 8:19 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux-Arch, linuxppc-dev, Paul Mackerras, linux-kernel
On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote:
> On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > Use the __weak macro instead of the longer __attribute__ ((weak)) form
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > --
> >
> > init/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
> > +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
> > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
> > cpu_set(cpu, cpu_possible_map);
> > }
> >
> > -void __init __attribute__((weak)) smp_setup_processor_id(void)
> > +void __init __weak smp_setup_processor_id(void)
> > {
> > }
>
> ack on all three. Please fold #3 into #1 and add both to git-powerpc.
Damn ! I took 5mn to actually split it out in order to not do two
different things in one patch :-)
Will do.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
2008-04-18 8:19 ` Benjamin Herrenschmidt
@ 2008-04-18 8:38 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2008-04-18 8:38 UTC (permalink / raw)
To: benh; +Cc: Linux-Arch, linuxppc-dev, Paul Mackerras, linux-kernel
On Fri, 18 Apr 2008 18:19:07 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote:
> > On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > Use the __weak macro instead of the longer __attribute__ ((weak)) form
> > >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > --
> > >
> > > init/main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
> > > +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
> > > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
> > > cpu_set(cpu, cpu_possible_map);
> > > }
> > >
> > > -void __init __attribute__((weak)) smp_setup_processor_id(void)
> > > +void __init __weak smp_setup_processor_id(void)
> > > {
> > > }
> >
> > ack on all three. Please fold #3 into #1 and add both to git-powerpc.
>
> Damn ! I took 5mn to actually split it out in order to not do two
> different things in one patch :-)
ah, I misread it. I thought this was changing the __attribute__((weak))
which patch #1 added. But it's changing a different one. I though that
was odd.
> Will do.
whatever ;)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-04-18 8:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-18 6:56 [PATCH 3/3] Use __weak macro for smp_setup_processor_id Benjamin Herrenschmidt
2008-04-18 7:07 ` Andrew Morton
2008-04-18 8:19 ` Benjamin Herrenschmidt
2008-04-18 8:38 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).