From: Sascha Hauer <s.hauer@pengutronix.de>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: mpc5200: add interrupt type function
Date: Fri, 18 Apr 2008 10:19:45 +0200 [thread overview]
Message-ID: <20080418081945.GO14658@pengutronix.de> (raw)
In-Reply-To: <fa686aa40804162341h5e68e460t975f69118ff8beca@mail.gmail.com>
On Wed, Apr 16, 2008 at 11:41:08PM -0700, Grant Likely wrote:
> On Wed, Apr 16, 2008 at 11:00 PM, Robert Schwebel
> <r.schwebel@pengutronix.de> wrote:
> > On Tue, Apr 15, 2008 at 05:29:54PM +0200, Robert Schwebel wrote:
> > > From: Sascha Hauer <s.hauer@pengutronix.de>
> > >
> > > Add a set_type function for external (GPIO) interrupts.
> > >
> > > Signed-off-by: Juergen Beisert <j.beisert@pengutronix.de>
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >
> > As we didn't get negative feedback yet, could this go into the 2.6.26
> > merge window?
>
> I didn't see this the first time (didn't get cc'd).
>
> It looks mostly okay, but in doesn't have any mutual exclusion which
> it probably should have. What are the users of this?
No, it is used in kernel/irq/chip.c and kernel/irq/manage.c. Both
callers already hold the mpc52xx_extirq_irqchip.lock spinlock.
Sascha
--
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-
prev parent reply other threads:[~2008-04-18 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-15 15:29 mpc5200: add interrupt type function Robert Schwebel
2008-04-17 6:00 ` Robert Schwebel
2008-04-17 6:41 ` Grant Likely
2008-04-18 8:19 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418081945.GO14658@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).