LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC POWERPC] booting-without-of: bindings for FHCI USB, GPIO LEDs, MCU, and NAND on UPM
Date: Tue, 22 Apr 2008 15:20:23 -0500	[thread overview]
Message-ID: <20080422202023.GA23165@ld0162-tx32.am.freescale.net> (raw)
In-Reply-To: <fa686aa40804221308w5960ces1f03a6a8c049edd4@mail.gmail.com>

On Tue, Apr 22, 2008 at 02:08:45PM -0600, Grant Likely wrote:
> > +    Example:
> > +
> > +       usb-pram@8b00 {
> > +               compatible = "fsl,mpc8360-qe-muram-usb-pram",
> > +                            "fsl,qe-muram-usb-pram",
> > +                            "fsl,cpm-muram-usb-pram";
> > +               reg = <0x8b00 0x100>;
> > +       };

Why not put it as an additional reg resource on the ucc node, instead of
in its own node?  That's how existing CPM bindings do it.

> > +    t) Freescale QUICC Engine USB Controller
> > +
> > +    Required properties:
> > +      - compatible : should be "fsl,<chip>-qe-usb", "fsl,qe-usb",
> > +        "fsl,usb-fhci"
> 
> Again, I'd leave out "fsl,qe-usb" and "fsl,usb-fhci".

QE is the name of a specific IP block, and is unlikely to be broken in a
non-backwards-compatible manner without having a new name such as QE2.  I
think this is taking "no generic names" too far.  If these names *are*
left out, then at least document which chip we're supposed to pick out of
a hat to claim compatibility with.

-Scott

  reply	other threads:[~2008-04-22 20:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 19:41 [RFC POWERPC] booting-without-of: bindings for FHCI USB, GPIO LEDs, MCU, and NAND on UPM Anton Vorontsov
2008-04-22 20:08 ` Grant Likely
2008-04-22 20:20   ` Scott Wood [this message]
2008-04-22 20:26     ` Grant Likely
2008-04-22 20:50   ` Josh Boyer
2008-04-23  0:37     ` Anton Vorontsov
2008-04-23  0:37   ` Anton Vorontsov
2008-04-23  3:22     ` Grant Likely
2008-04-23  9:15 ` Laurent Pinchart
2008-04-23 14:01   ` Anton Vorontsov
2008-04-24 17:52 ` [RFCv2 " Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080422202023.GA23165@ld0162-tx32.am.freescale.net \
    --to=scottwood@freescale.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox