* new warnings from stacktrace patch
@ 2008-04-23 7:59 Stephen Rothwell
2008-04-23 14:32 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2008-04-23 7:59 UTC (permalink / raw)
To: Paul Mackerras; +Cc: Christoph Hellwig, ppc-dev
[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]
Hi all,
Linus' kernel today produces these warnings for an allyesconfig build:
(it was actually a linux-next build, but the commit is in Linus' tree)
In file included from arch/powerpc/kernel/stacktrace.c:16:
include/asm/asm-offsets.h:113:1: warning: "CLONE_VM" redefined
In file included from arch/powerpc/kernel/stacktrace.c:13:
include/linux/sched.h:8:1: warning: this is the location of the previous definition
In file included from arch/powerpc/kernel/stacktrace.c:16:
include/asm/asm-offsets.h:114:1: warning: "CLONE_UNTRACED" redefined
In file included from arch/powerpc/kernel/stacktrace.c:13:
include/linux/sched.h:22:1: warning: this is the location of the previous definition
In file included from arch/powerpc/kernel/stacktrace.c:16:
include/asm/asm-offsets.h:151:1: warning: "NSEC_PER_SEC" redefined
In file included from include/linux/timex.h:57,
from include/linux/sched.h:54,
from arch/powerpc/kernel/stacktrace.c:13:
include/linux/time.h:37:1: warning: this is the location of the previous definition
This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
Stacktrace support for lockdep"). We don't include asm-offsets.h in any
other C file in the powerpc build.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: new warnings from stacktrace patch
2008-04-23 7:59 new warnings from stacktrace patch Stephen Rothwell
@ 2008-04-23 14:32 ` Christoph Hellwig
2008-04-24 0:44 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2008-04-23 14:32 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: ppc-dev, Paul Mackerras, Christoph Hellwig
On Wed, Apr 23, 2008 at 05:59:38PM +1000, Stephen Rothwell wrote:
> This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
> Stacktrace support for lockdep"). We don't include asm-offsets.h in any
> other C file in the powerpc build.
I think the include can be safely removed.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/arch/powerpc/kernel/stacktrace.c
===================================================================
--- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:05.000000000 +0200
+++ linux-2.6/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:16.000000000 +0200
@@ -13,7 +13,6 @@
#include <linux/sched.h>
#include <linux/stacktrace.h>
#include <asm/ptrace.h>
-#include <asm/asm-offsets.h>
/*
* Save stack-backtrace addresses into a stack_trace buffer.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: new warnings from stacktrace patch
2008-04-23 14:32 ` Christoph Hellwig
@ 2008-04-24 0:44 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-04-24 0:44 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Stephen Rothwell, Paul Mackerras, ppc-dev
On Wed, 2008-04-23 at 16:32 +0200, Christoph Hellwig wrote:
> On Wed, Apr 23, 2008 at 05:59:38PM +1000, Stephen Rothwell wrote:
> > This is from commit fd3e0bbc6052ca9747a5332b382584ece83aab6d ("[POWERPC]
> > Stacktrace support for lockdep"). We don't include asm-offsets.h in any
> > other C file in the powerpc build.
>
> I think the include can be safely removed.
Yup. It's a leftover from before I fixed up some stuff in ptrace.h
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Ack.
> Index: linux-2.6/arch/powerpc/kernel/stacktrace.c
> ===================================================================
> --- linux-2.6.orig/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:05.000000000 +0200
> +++ linux-2.6/arch/powerpc/kernel/stacktrace.c 2008-04-23 15:28:16.000000000 +0200
> @@ -13,7 +13,6 @@
> #include <linux/sched.h>
> #include <linux/stacktrace.h>
> #include <asm/ptrace.h>
> -#include <asm/asm-offsets.h>
>
> /*
> * Save stack-backtrace addresses into a stack_trace buffer.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-04-24 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-04-23 7:59 new warnings from stacktrace patch Stephen Rothwell
2008-04-23 14:32 ` Christoph Hellwig
2008-04-24 0:44 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).