From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e2.ny.us.ibm.com (e2.ny.us.ibm.com [32.97.182.142]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "e2.ny.us.ibm.com", Issuer "Equifax" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 668FDDE4B7 for ; Fri, 25 Apr 2008 23:24:55 +1000 (EST) Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m3PDOqGI014373 for ; Fri, 25 Apr 2008 09:24:52 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m3PDOq8s252998 for ; Fri, 25 Apr 2008 09:24:52 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m3PDOfIC018436 for ; Fri, 25 Apr 2008 09:24:42 -0400 Date: Fri, 25 Apr 2008 08:19:08 -0500 From: Josh Boyer To: benh@kernel.crashing.org Subject: Re: [PATCH v2] [POWERPC] 4xx: Add endpoint support to 4xx PCIe driver Message-ID: <20080425081908.4022db0b@zod.rchland.ibm.com> In-Reply-To: <1209128284.5420.0.camel@pasglop> References: <1208789670-28909-1-git-send-email-sr@denx.de> <1209104641.9060.228.camel@pasglop> <20080425053724.5b3eeb2f@zod.rchland.ibm.com> <1209128284.5420.0.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linuxppc-dev@ozlabs.org, Stefan Roese , Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 25 Apr 2008 22:58:04 +1000 Benjamin Herrenschmidt wrote: > > On Fri, 2008-04-25 at 05:37 -0500, Josh Boyer wrote: > > On Fri, 25 Apr 2008 16:24:01 +1000 > > Benjamin Herrenschmidt wrote: > > > > > > > > On Mon, 2008-04-21 at 16:54 +0200, Stefan Roese wrote: > > > > This patch adds basic endpoint support to the 4xx PCIe driver. > > > > > > > > This is done by checking the device_type property of the PCIe > > > > device node ("pci" for root-complex and "pci-endpoint" for endpoint > > > > configuration). > > > > > > > > Note: Currently we map a fixed 64MByte window to PLB address 0 (SDRAM). > > > > This should probably be configurable via a dts property. > > > > > > > > Signed-off-by: Stefan Roese > > > > > > Acked-by: Benjamin Herrenschmidt > > > --- > > > > > > Paul, I forgot to send that ack a while ago, this is .26 material, been > > > around for some time. > > > > I'll add it to my tree. And this version of the patch was only sent > > out on Monday. > > True but I'm to blame for waiting too long to review it... Oh, for sure. We blame you for all kinds of things. It's just easier that way ;) josh