From: Sascha Hauer <s.hauer@pengutronix.de>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] add gpiolib support for mpc5200
Date: Fri, 25 Apr 2008 15:42:59 +0200 [thread overview]
Message-ID: <20080425134259.GO6692@pengutronix.de> (raw)
In-Reply-To: <20080425130737.GA3430@polina.dev.rtsoft.ru>
On Fri, Apr 25, 2008 at 05:07:37PM +0400, Anton Vorontsov wrote:
> On Thu, Apr 24, 2008 at 05:36:59PM +0200, Sascha Hauer wrote:
>
> > +#include <linux/of.h>
> > +#include <linux/kernel.h>
> > +#include <linux/of_gpio.h>
> > +#include <linux/io.h>
> > +#include <asm/of_platform.h>
> > +#include <asm/prom.h>
> > +#include <asm/gpio.h>
>
> In the latest kernels the preferred way is to include <linux/gpio.h>,
> the patch introducing it was merged just recently, so few people know
> about it yet.
Yes, checkpatch told me, but doing so resulted in a compilation error.
This only showed that a "select GENERIC_GPIO" was missing in my
patch. Will update.
Sascha
--
Pengutronix e.K. - Linux Solutions for Science and Industry
-----------------------------------------------------------
Kontakt-Informationen finden Sie im Header dieser Mail oder
auf der Webseite -> http://www.pengutronix.de/impressum/ <-
prev parent reply other threads:[~2008-04-25 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-24 15:36 [PATCH] add gpiolib support for mpc5200 Sascha Hauer
2008-04-24 18:45 ` Grant Likely
2008-04-25 10:53 ` Sascha Hauer
2008-04-25 12:32 ` Anton Vorontsov
2008-04-25 15:30 ` Matt Sealey
2008-04-25 18:51 ` Sascha Hauer
2008-04-25 19:30 ` Grant Likely
2008-04-24 19:11 ` Grant Likely
2008-04-25 8:22 ` Stephen Rothwell
2008-04-25 10:56 ` Sascha Hauer
2008-04-25 13:07 ` Anton Vorontsov
2008-04-25 13:42 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425134259.GO6692@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).