From: Dale Farnsworth <dale@farnsworth.org>
To: Remi Machet <rmachet@slac.stanford.edu>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] sysdev,mv64x60: MV64x60 device bus
Date: Mon, 28 Apr 2008 11:09:47 -0700 [thread overview]
Message-ID: <20080428180947.GA2691@farnsworth.org> (raw)
In-Reply-To: <1209402729.14407.2.camel@pcds-ts102.slac.stanford.edu>
On Mon, Apr 28, 2008 at 10:12:09AM -0700, Remi Machet wrote:
> Follow up of my email of 4/16/2008 titled "MV64x60 device bus".
> For each mv64360 entry in the OpenFirmware database, add the
> registration of an of_bus to take care of devices connected to
> the MV64x60 asynchronous devices controller.
I'd like to see your dts file to see exactly how you're using it.
The only problem I see now is that you have introduced a new device
type, "devicectrl". New device types are frowned upon. It's better
to match based on the compatible field. Maybe use
"marvell,mv64306-devctrl" or similar.
-Dale
next prev parent reply other threads:[~2008-04-28 18:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-28 17:12 [PATCH] sysdev,mv64x60: MV64x60 device bus Remi Machet
2008-04-28 18:09 ` Dale Farnsworth [this message]
2008-04-28 19:22 ` Remi Machet
2008-04-28 19:25 ` Dale Farnsworth
2008-04-29 1:54 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080428180947.GA2691@farnsworth.org \
--to=dale@farnsworth.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=rmachet@slac.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).