Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Andrew Morton]

On Tue, 29 Apr 2008 20:10:55 -0700 (PDT)
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Don't refer to file that no longer exists:
> docproc: linux-2.6.25-git14/arch/powerpc/kernel/rio.c: No such file or directory
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  Documentation/DocBook/rapidio.tmpl |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- linux-2.6.25-git14.orig/Documentation/DocBook/rapidio.tmpl
> +++ linux-2.6.25-git14/Documentation/DocBook/rapidio.tmpl
> @@ -133,7 +133,6 @@
>  !Idrivers/rapidio/rio-sysfs.c
>       </sect1>
>       <sect1 id="PPC32_support"><title>PPC32 support</title>
> -!Iarch/powerpc/kernel/rio.c
>  !Earch/powerpc/sysdev/fsl_rio.c
>  !Iarch/powerpc/sysdev/fsl_rio.c
>       </sect1>

grumble.

This is a subset of rapidio-fix-docbook-references.patch, but I appear to
be unable to interest anyone in merging/reviewing/accepting/anything-else
that quite large set of patches.

Guys, those patches were sent six weeks ago and it now looks like they will
miss 2.6.26.  This is pretty slack of us.  Help?

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Randy Dunlap]

On Wed, 30 Apr 2008 11:35:00 -0700 Andrew Morton wrote:

> On Tue, 29 Apr 2008 20:10:55 -0700 (PDT)
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Don't refer to file that no longer exists:
> > docproc: linux-2.6.25-git14/arch/powerpc/kernel/rio.c: No such file or directory
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >  Documentation/DocBook/rapidio.tmpl |    1 -
> >  1 file changed, 1 deletion(-)
> > 
> > --- linux-2.6.25-git14.orig/Documentation/DocBook/rapidio.tmpl
> > +++ linux-2.6.25-git14/Documentation/DocBook/rapidio.tmpl
> > @@ -133,7 +133,6 @@
> >  !Idrivers/rapidio/rio-sysfs.c
> >       </sect1>
> >       <sect1 id="PPC32_support"><title>PPC32 support</title>
> > -!Iarch/powerpc/kernel/rio.c
> >  !Earch/powerpc/sysdev/fsl_rio.c
> >  !Iarch/powerpc/sysdev/fsl_rio.c
> >       </sect1>
> 
> grumble.
> 
> This is a subset of rapidio-fix-docbook-references.patch, but I appear to
> be unable to interest anyone in merging/reviewing/accepting/anything-else
> that quite large set of patches.
> 
> Guys, those patches were sent six weeks ago and it now looks like they will
> miss 2.6.26.  This is pretty slack of us.  Help?

There's nothing there that can hurt.  (famous last words)

Just merge it.

---
~Randy

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Kumar Gala]

On Apr 30, 2008, at 1:35 PM, Andrew Morton wrote:
> On Tue, 29 Apr 2008 20:10:55 -0700 (PDT)
> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Don't refer to file that no longer exists:
>> docproc: linux-2.6.25-git14/arch/powerpc/kernel/rio.c: No such file  
>> or directory
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> ---
>> Documentation/DocBook/rapidio.tmpl |    1 -
>> 1 file changed, 1 deletion(-)
>>
>> --- linux-2.6.25-git14.orig/Documentation/DocBook/rapidio.tmpl
>> +++ linux-2.6.25-git14/Documentation/DocBook/rapidio.tmpl
>> @@ -133,7 +133,6 @@
>> !Idrivers/rapidio/rio-sysfs.c
>>      </sect1>
>>      <sect1 id="PPC32_support"><title>PPC32 support</title>
>> -!Iarch/powerpc/kernel/rio.c
>> !Earch/powerpc/sysdev/fsl_rio.c
>> !Iarch/powerpc/sysdev/fsl_rio.c
>>      </sect1>
>
> grumble.
>
> This is a subset of rapidio-fix-docbook-references.patch, but I  
> appear to
> be unable to interest anyone in merging/reviewing/accepting/anything- 
> else
> that quite large set of patches.
>
> Guys, those patches were sent six weeks ago and it now looks like  
> they will
> miss 2.6.26.  This is pretty slack of us.  Help?

Odd.  I thought Paul had picked up a docbook RapidIO patch from you in  
the latest merge round.

- k

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Andrew Morton]

On Wed, 30 Apr 2008 14:01:12 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:

> 
> On Apr 30, 2008, at 1:35 PM, Andrew Morton wrote:
> > On Tue, 29 Apr 2008 20:10:55 -0700 (PDT)
> > "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> >
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> Don't refer to file that no longer exists:
> >> docproc: linux-2.6.25-git14/arch/powerpc/kernel/rio.c: No such file  
> >> or directory
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >> ---
> >> Documentation/DocBook/rapidio.tmpl |    1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> --- linux-2.6.25-git14.orig/Documentation/DocBook/rapidio.tmpl
> >> +++ linux-2.6.25-git14/Documentation/DocBook/rapidio.tmpl
> >> @@ -133,7 +133,6 @@
> >> !Idrivers/rapidio/rio-sysfs.c
> >>      </sect1>
> >>      <sect1 id="PPC32_support"><title>PPC32 support</title>
> >> -!Iarch/powerpc/kernel/rio.c
> >> !Earch/powerpc/sysdev/fsl_rio.c
> >> !Iarch/powerpc/sysdev/fsl_rio.c
> >>      </sect1>
> >
> > grumble.
> >
> > This is a subset of rapidio-fix-docbook-references.patch, but I  
> > appear to
> > be unable to interest anyone in merging/reviewing/accepting/anything- 
> > else
> > that quite large set of patches.
> >
> > Guys, those patches were sent six weeks ago and it now looks like  
> > they will
> > miss 2.6.26.  This is pretty slack of us.  Help?
> 
> Odd.  I thought Paul had picked up a docbook RapidIO patch from you in  
> the latest merge round.
> 

Well it's more than "a" patch.  The six-week-old patch series is:

rapidio-add-memory-mapping-driver-to-rapidio.patch
rapidio-add-rapidio-space-allocation-bitmap-arithmetic.patch
rapidio-add-fsl-rapidio-controller-memory-ops-functions.patch
rapidio-add-the-rapidio-master-port-maintance-and-doorbell-window-to-space-resources.patch
rapidio-add-rapidio-proc-fs-for-memory-mapping-debugging.patch
rapidio-add-the-memory-mapping-support-in-rionet-driver.patch
rapidio-fix-docbook-references.patch
rapidio-fix-kernel-doc-problems.patch

totalling:

 arch/powerpc/sysdev/fsl_rio.c       |   13 +
 include/linux/rio.h                 |   10 
 drivers/net/Kconfig                 |   10 
 drivers/net/rionet.c                |  324 ++++++++++++++++++++++++++++++
 drivers/rapidio/Makefile            |    1 
 drivers/rapidio/rio.c               |   10 
 drivers/rapidio/sallocator/Kconfig  |    9 
 drivers/rapidio/sallocator/Makefile |   12 +
 drivers/rapidio/sallocator/bitmap.c |  384 ++++++++++++++++++++++++++++++++++++
 include/linux/rio.h                 |   10 
 include/linux/rio_drv.h             |   41 +++
 16 files changed, 1425 insertions(+), 14 deletions(-)


(seems that I forgot to cc Jeff on the rionet change too).


Oh well.  If nobody puts their hand up in the next 24 hours or so I'll just
send it all in to Linus.

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Kumar Gala]

On Apr 30, 2008, at 2:12 PM, Andrew Morton wrote:
> On Wed, 30 Apr 2008 14:01:12 -0500
> Kumar Gala <galak@kernel.crashing.org> wrote:
>
>>
>> On Apr 30, 2008, at 1:35 PM, Andrew Morton wrote:
>>> On Tue, 29 Apr 2008 20:10:55 -0700 (PDT)
>>> "Randy.Dunlap" <rdunlap@xenotime.net> wrote:
>>>
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> Don't refer to file that no longer exists:
>>>> docproc: linux-2.6.25-git14/arch/powerpc/kernel/rio.c: No such file
>>>> or directory
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>>> ---
>>>> Documentation/DocBook/rapidio.tmpl |    1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> --- linux-2.6.25-git14.orig/Documentation/DocBook/rapidio.tmpl
>>>> +++ linux-2.6.25-git14/Documentation/DocBook/rapidio.tmpl
>>>> @@ -133,7 +133,6 @@
>>>> !Idrivers/rapidio/rio-sysfs.c
>>>>     </sect1>
>>>>     <sect1 id="PPC32_support"><title>PPC32 support</title>
>>>> -!Iarch/powerpc/kernel/rio.c
>>>> !Earch/powerpc/sysdev/fsl_rio.c
>>>> !Iarch/powerpc/sysdev/fsl_rio.c
>>>>     </sect1>
>>>
>>> grumble.
>>>
>>> This is a subset of rapidio-fix-docbook-references.patch, but I
>>> appear to
>>> be unable to interest anyone in merging/reviewing/accepting/ 
>>> anything-
>>> else
>>> that quite large set of patches.
>>>
>>> Guys, those patches were sent six weeks ago and it now looks like
>>> they will
>>> miss 2.6.26.  This is pretty slack of us.  Help?
>>
>> Odd.  I thought Paul had picked up a docbook RapidIO patch from you  
>> in
>> the latest merge round.
>>
>
> Well it's more than "a" patch.  The six-week-old patch series is:
>
> rapidio-add-memory-mapping-driver-to-rapidio.patch
> rapidio-add-rapidio-space-allocation-bitmap-arithmetic.patch
> rapidio-add-fsl-rapidio-controller-memory-ops-functions.patch
> rapidio-add-the-rapidio-master-port-maintance-and-doorbell-window-to- 
> space-resources.patch
> rapidio-add-rapidio-proc-fs-for-memory-mapping-debugging.patch
> rapidio-add-the-memory-mapping-support-in-rionet-driver.patch
> rapidio-fix-docbook-references.patch
> rapidio-fix-kernel-doc-problems.patch
>
> totalling:
>
> arch/powerpc/sysdev/fsl_rio.c       |   13 +
> include/linux/rio.h                 |   10
> drivers/net/Kconfig                 |   10
> drivers/net/rionet.c                |  324 ++++++++++++++++++++++++++ 
> ++++
> drivers/rapidio/Makefile            |    1
> drivers/rapidio/rio.c               |   10
> drivers/rapidio/sallocator/Kconfig  |    9
> drivers/rapidio/sallocator/Makefile |   12 +
> drivers/rapidio/sallocator/bitmap.c |  384 ++++++++++++++++++++++++++ 
> ++++++++++
> include/linux/rio.h                 |   10
> include/linux/rio_drv.h             |   41 +++
> 16 files changed, 1425 insertions(+), 14 deletions(-)
>
>
> (seems that I forgot to cc Jeff on the rionet change too).
>
>
> Oh well.  If nobody puts their hand up in the next 24 hours or so  
> I'll just
> send it all in to Linus.

I'm raising my hand.  The memory map driver needs further review.  If  
the Docbook issues can be applied w/o the other patches I suggest we  
go forward with those.

- k

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Paul Mackerras]

Andrew Morton writes:

> > Odd.  I thought Paul had picked up a docbook RapidIO patch from you in  
> > the latest merge round.
> > 
> 
> Well it's more than "a" patch.  The six-week-old patch series is:
> 
> rapidio-add-memory-mapping-driver-to-rapidio.patch
> rapidio-add-rapidio-space-allocation-bitmap-arithmetic.patch
> rapidio-add-fsl-rapidio-controller-memory-ops-functions.patch
> rapidio-add-the-rapidio-master-port-maintance-and-doorbell-window-to-space-resources.patch
> rapidio-add-rapidio-proc-fs-for-memory-mapping-debugging.patch
> rapidio-add-the-memory-mapping-support-in-rionet-driver.patch
> rapidio-fix-docbook-references.patch
> rapidio-fix-kernel-doc-problems.patch

What happened is that you (Andrew) sent them on to me pretty much
unexamined.  I took a look at them and dropped one of them because it
created a new /proc file.  I asked Kumar to look at them and he had
issues with another three of the patches, and dropping those meant
that all the following ones (including the fix-kernel-doc one)
wouldn't apply, so I dropped them too.  I applied the rest and sent
them to Linus.

> (seems that I forgot to cc Jeff on the rionet change too).

Yeah.  I nearly dropped that one too.  I probably should have. :)

> Oh well.  If nobody puts their hand up in the next 24 hours or so I'll just
> send it all in to Linus.

Please don't.  At this stage I think the best thing is for Kumar to
talk to Zhang Wei (they both work for Freescale, so that should be
possible in theory :) and get him to rework the remaining patches as
required for inclusion in 2.6.27.

Paul.

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Randy Dunlap]

On Thu, 1 May 2008 08:09:24 +1000 Paul Mackerras wrote:

> Andrew Morton writes:
> 
> > > Odd.  I thought Paul had picked up a docbook RapidIO patch from you in  
> > > the latest merge round.
> > > 
> > 
> > Well it's more than "a" patch.  The six-week-old patch series is:
> > 
> > rapidio-add-memory-mapping-driver-to-rapidio.patch
> > rapidio-add-rapidio-space-allocation-bitmap-arithmetic.patch
> > rapidio-add-fsl-rapidio-controller-memory-ops-functions.patch
> > rapidio-add-the-rapidio-master-port-maintance-and-doorbell-window-to-space-resources.patch
> > rapidio-add-rapidio-proc-fs-for-memory-mapping-debugging.patch
> > rapidio-add-the-memory-mapping-support-in-rionet-driver.patch
> > rapidio-fix-docbook-references.patch
> > rapidio-fix-kernel-doc-problems.patch
> 
> What happened is that you (Andrew) sent them on to me pretty much
> unexamined.  I took a look at them and dropped one of them because it
> created a new /proc file.  I asked Kumar to look at them and he had
> issues with another three of the patches, and dropping those meant
> that all the following ones (including the fix-kernel-doc one)
> wouldn't apply, so I dropped them too.  I applied the rest and sent
> them to Linus.
> 
> > (seems that I forgot to cc Jeff on the rionet change too).
> 
> Yeah.  I nearly dropped that one too.  I probably should have. :)
> 
> > Oh well.  If nobody puts their hand up in the next 24 hours or so I'll just
> > send it all in to Linus.
> 
> Please don't.  At this stage I think the best thing is for Kumar to
> talk to Zhang Wei (they both work for Freescale, so that should be
> possible in theory :) and get him to rework the remaining patches as
> required for inclusion in 2.6.27.

Just to be clear, the docbook changes shouldn't wait for 2.6.27.
There's no need for that.

---
~Randy

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Kumar Gala]

On Apr 30, 2008, at 5:11 PM, Randy Dunlap wrote:
> On Thu, 1 May 2008 08:09:24 +1000 Paul Mackerras wrote:
>
>> Andrew Morton writes:
>>
>>>> Odd.  I thought Paul had picked up a docbook RapidIO patch from  
>>>> you in
>>>> the latest merge round.
>>>>
>>>
>>> Well it's more than "a" patch.  The six-week-old patch series is:
>>>
>>> rapidio-add-memory-mapping-driver-to-rapidio.patch
>>> rapidio-add-rapidio-space-allocation-bitmap-arithmetic.patch
>>> rapidio-add-fsl-rapidio-controller-memory-ops-functions.patch
>>> rapidio-add-the-rapidio-master-port-maintance-and-doorbell-window- 
>>> to-space-resources.patch
>>> rapidio-add-rapidio-proc-fs-for-memory-mapping-debugging.patch
>>> rapidio-add-the-memory-mapping-support-in-rionet-driver.patch
>>> rapidio-fix-docbook-references.patch
>>> rapidio-fix-kernel-doc-problems.patch
>>
>> What happened is that you (Andrew) sent them on to me pretty much
>> unexamined.  I took a look at them and dropped one of them because it
>> created a new /proc file.  I asked Kumar to look at them and he had
>> issues with another three of the patches, and dropping those meant
>> that all the following ones (including the fix-kernel-doc one)
>> wouldn't apply, so I dropped them too.  I applied the rest and sent
>> them to Linus.
>>
>>> (seems that I forgot to cc Jeff on the rionet change too).
>>
>> Yeah.  I nearly dropped that one too.  I probably should have. :)
>>
>>> Oh well.  If nobody puts their hand up in the next 24 hours or so  
>>> I'll just
>>> send it all in to Linus.
>>
>> Please don't.  At this stage I think the best thing is for Kumar to
>> talk to Zhang Wei (they both work for Freescale, so that should be
>> possible in theory :) and get him to rework the remaining patches as
>> required for inclusion in 2.6.27.
>
> Just to be clear, the docbook changes shouldn't wait for 2.6.27.
> There's no need for that.

Can the docbook be respun against linus's tree?

-k

Re: [PATCH] docbook: fix fatal rapidio yet again (and more to come)

[Randy Dunlap]

Kumar Gala wrote:
> 
> On Apr 30, 2008, at 5:11 PM, Randy Dunlap wrote:
>> On Thu, 1 May 2008 08:09:24 +1000 Paul Mackerras wrote:
>>
>>> Andrew Morton writes:
>>>
>>>>> Odd.  I thought Paul had picked up a docbook RapidIO patch from you in
>>>>> the latest merge round.
>>>>>
>>>>
>>>> Well it's more than "a" patch.  The six-week-old patch series is:
>>>>
>>>> rapidio-add-memory-mapping-driver-to-rapidio.patch
>>>> rapidio-add-rapidio-space-allocation-bitmap-arithmetic.patch
>>>> rapidio-add-fsl-rapidio-controller-memory-ops-functions.patch
>>>> rapidio-add-the-rapidio-master-port-maintance-and-doorbell-window-to-space-resources.patch 
>>>>
>>>> rapidio-add-rapidio-proc-fs-for-memory-mapping-debugging.patch
>>>> rapidio-add-the-memory-mapping-support-in-rionet-driver.patch
>>>> rapidio-fix-docbook-references.patch
>>>> rapidio-fix-kernel-doc-problems.patch
>>>
>>> What happened is that you (Andrew) sent them on to me pretty much
>>> unexamined.  I took a look at them and dropped one of them because it
>>> created a new /proc file.  I asked Kumar to look at them and he had
>>> issues with another three of the patches, and dropping those meant
>>> that all the following ones (including the fix-kernel-doc one)
>>> wouldn't apply, so I dropped them too.  I applied the rest and sent
>>> them to Linus.
>>>
>>>> (seems that I forgot to cc Jeff on the rionet change too).
>>>
>>> Yeah.  I nearly dropped that one too.  I probably should have. :)
>>>
>>>> Oh well.  If nobody puts their hand up in the next 24 hours or so 
>>>> I'll just
>>>> send it all in to Linus.
>>>
>>> Please don't.  At this stage I think the best thing is for Kumar to
>>> talk to Zhang Wei (they both work for Freescale, so that should be
>>> possible in theory :) and get him to rework the remaining patches as
>>> required for inclusion in 2.6.27.
>>
>> Just to be clear, the docbook changes shouldn't wait for 2.6.27.
>> There's no need for that.
> 
> Can the docbook be respun against linus's tree?

Sure, I'll do that later, hopefully tonight.

-- 
~Randy

[PATCH] rapidio: fix current kernel-doc notation

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix current (-git16) missing docbook/kernel-doc notation in RapidIO files.

Warning(linux-2.6.25-git16//include/linux/rio.h:187): No description found for parameter 'sys_size'
Warning(linux-2.6.25-git16//include/linux/rio.h:187): No description found for parameter 'phy_type'

Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:188): No description found for parameter 'mport'
Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:224): No description found for parameter 'mport'
Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:245): No description found for parameter 'mport'
Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:270): No description found for parameter 'mport'
Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:311): No description found for parameter 'mport'
Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:996): No description found for parameter 'dev'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 arch/powerpc/sysdev/fsl_rio.c |    9 +++++++--
 include/linux/rio.h           |    2 ++
 2 files changed, 9 insertions(+), 2 deletions(-)

--- linux-2.6.25-git16.orig/include/linux/rio.h
+++ linux-2.6.25-git16/include/linux/rio.h
@@ -161,6 +161,8 @@ enum rio_phy_type {
  * @ops: configuration space functions
  * @id: Port ID, unique among all ports
  * @index: Port index, unique among all port interfaces of the same type
+ * @sys_size: RapidIO common transport system size
+ * @phy_type: RapidIO phy type
  * @name: Port name string
  * @priv: Master port private data
  */
--- linux-2.6.25-git16.orig/arch/powerpc/sysdev/fsl_rio.c
+++ linux-2.6.25-git16/arch/powerpc/sysdev/fsl_rio.c
@@ -176,6 +176,7 @@ struct rio_priv {
 
 /**
  * fsl_rio_doorbell_send - Send a MPC85xx doorbell message
+ * @mport: RapidIO master port info
  * @index: ID of RapidIO interface
  * @destid: Destination ID of target device
  * @data: 16-bit info field of RapidIO doorbell message
@@ -211,6 +212,7 @@ static int fsl_rio_doorbell_send(struct 
 
 /**
  * fsl_local_config_read - Generate a MPC85xx local config space read
+ * @mport: RapidIO master port info
  * @index: ID of RapdiIO interface
  * @offset: Offset into configuration space
  * @len: Length (in bytes) of the maintenance transaction
@@ -232,6 +234,7 @@ static int fsl_local_config_read(struct 
 
 /**
  * fsl_local_config_write - Generate a MPC85xx local config space write
+ * @mport: RapidIO master port info
  * @index: ID of RapdiIO interface
  * @offset: Offset into configuration space
  * @len: Length (in bytes) of the maintenance transaction
@@ -254,6 +257,7 @@ static int fsl_local_config_write(struct
 
 /**
  * fsl_rio_config_read - Generate a MPC85xx read maintenance transaction
+ * @mport: RapidIO master port info
  * @index: ID of RapdiIO interface
  * @destid: Destination ID of transaction
  * @hopcount: Number of hops to target device
@@ -295,6 +299,7 @@ fsl_rio_config_read(struct rio_mport *mp
 
 /**
  * fsl_rio_config_write - Generate a MPC85xx write maintenance transaction
+ * @mport: RapidIO master port info
  * @index: ID of RapdiIO interface
  * @destid: Destination ID of transaction
  * @hopcount: Number of hops to target device
@@ -985,8 +990,8 @@ static inline void fsl_rio_info(struct d
 }
 
 /**
- * fsl_rio_setup - Setup MPC85xx RapidIO interface
- * @fsl_rio_setup - Setup Freescale PowerPC RapidIO interface
+ * fsl_rio_setup - Setup Freescale PowerPC RapidIO interface
+ * @dev: of_device pointer
  *
  * Initializes MPC85xx RapidIO hardware interface, configures
  * master port with system-specific info, and registers the

Re: [PATCH] rapidio: fix current kernel-doc notation

[Kumar Gala]

On Apr 30, 2008, at 6:45 PM, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Fix current (-git16) missing docbook/kernel-doc notation in RapidIO  
> files.
>
> Warning(linux-2.6.25-git16//include/linux/rio.h:187): No description  
> found for parameter 'sys_size'
> Warning(linux-2.6.25-git16//include/linux/rio.h:187): No description  
> found for parameter 'phy_type'
>
> Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:188): No  
> description found for parameter 'mport'
> Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:224): No  
> description found for parameter 'mport'
> Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:245): No  
> description found for parameter 'mport'
> Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:270): No  
> description found for parameter 'mport'
> Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:311): No  
> description found for parameter 'mport'
> Warning(linux-2.6.25-git16//arch/powerpc/sysdev/fsl_rio.c:996): No  
> description found for parameter 'dev'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> arch/powerpc/sysdev/fsl_rio.c |    9 +++++++--
> include/linux/rio.h           |    2 ++
> 2 files changed, 9 insertions(+), 2 deletions(-)

applied.

- k