From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: spi-devel-general@lists.sourceforge.net, 12o3l@tiscali.nl,
linuxppc-dev@ozlabs.org
Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver
Date: Wed, 30 Apr 2008 15:55:33 -0700 [thread overview]
Message-ID: <200804301555.34110.david-b@pacbell.net> (raw)
In-Reply-To: <20080430154631.b86797de.akpm@linux-foundation.org>
On Wednesday 30 April 2008, Andrew Morton wrote:
> > + spin_lock_irq(&mpc83xx_spi->lock);
>
> irq-safe.
>
> > ...
> >
> > + spin_lock(&mpc83xx_spi->lock);
>
> not irq-safe.
>
> Deliberate?
That latter one is inside an #if 0/#endif block, so it won't matter.
The #if 0 block bothered me. Maybe Joakim can remove it.
(By the way, I'd feel safer about this patch if there were an
ack or two from more PPC folk...)
next prev parent reply other threads:[~2008-04-30 22:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-30 22:37 [patch 2.6.25-git] spi_mpc83xx much improved driver David Brownell
2008-04-30 22:46 ` Andrew Morton
2008-04-30 22:55 ` David Brownell [this message]
2008-05-01 10:42 ` Joakim Tjernlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804301555.34110.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).