drivers/net/fec_8xx config problem

drivers/net/fec_8xx config problem

[Becky Bruce]

I just noticed that the fec_8xx driver is not currently reachable via  
menuconfig because it depends on 8XX instead of 8xx.  It looks like  
this change occurred in commit  
d1c0a65fb597697d1fbce4eadf42b84f70483edc, almost a year ago:

diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
index a84c232..afb34de 100644
--- a/drivers/net/fec_8xx/Kconfig+++ b/drivers/net/fec_8xx/Kconfig
@@ -1,6 +1,6 @@
  config FEC_8XX
         tristate "Motorola 8xx FEC driver"
-       depends on NET_ETHERNET && 8xx
+       depends on 8XX
         select MII


Since nobody has noticed this problem, I'm wondering if this driver  
is still in (infrequent) use, or if it's been superseded and should  
be removed, or if I'm just completely missing something with respect  
to the use of "8XX" instead of "8xx".

I'm happy to submit a patch to correct this, I'm just not sure what  
the right answer is.

Thanks,
Becky

Re: drivers/net/fec_8xx config problem

[Scott Wood]

On Wed, Apr 30, 2008 at 02:19:21PM -0500, Becky Bruce wrote:
> I just noticed that the fec_8xx driver is not currently reachable via  
> menuconfig because it depends on 8XX instead of 8xx.
[snip]
> Since nobody has noticed this problem, I'm wondering if this driver  
> is still in (infrequent) use, or if it's been superseded and should  
> be removed, or if I'm just completely missing something with respect  
> to the use of "8XX" instead of "8xx".

It's been superseded by drivers/net/fs_enet.

-Scott

Re: drivers/net/fec_8xx config problem

[Becky Bruce]

On Apr 30, 2008, at 2:20 PM, Scott Wood wrote:
> On Wed, Apr 30, 2008 at 02:19:21PM -0500, Becky Bruce wrote:
>> I just noticed that the fec_8xx driver is not currently reachable via
>> menuconfig because it depends on 8XX instead of 8xx.
> [snip]
>> Since nobody has noticed this problem, I'm wondering if this driver
>> is still in (infrequent) use, or if it's been superseded and should
>> be removed, or if I'm just completely missing something with respect
>> to the use of "8XX" instead of "8xx".
>
> It's been superseded by drivers/net/fs_enet.

Is there any reason we haven't removed it?  If not, I can push a  
patch to yank it.

Cheers,
B

Re: drivers/net/fec_8xx config problem

[Scott Wood]

On Wed, Apr 30, 2008 at 02:24:19PM -0500, Becky Bruce wrote:
> 
> On Apr 30, 2008, at 2:20 PM, Scott Wood wrote:
> >On Wed, Apr 30, 2008 at 02:19:21PM -0500, Becky Bruce wrote:
> >>I just noticed that the fec_8xx driver is not currently reachable via
> >>menuconfig because it depends on 8XX instead of 8xx.
> >[snip]
> >>Since nobody has noticed this problem, I'm wondering if this driver
> >>is still in (infrequent) use, or if it's been superseded and should
> >>be removed, or if I'm just completely missing something with respect
> >>to the use of "8XX" instead of "8xx".
> >
> >It's been superseded by drivers/net/fs_enet.
> 
> Is there any reason we haven't removed it?

To keep arch/ppc/8xx_io company? :-)

> If not, I can push a patch to yank it.

I have no objection.

-Scott

Re: drivers/net/fec_8xx config problem

[Jan Engelhardt]

On Wednesday 2008-04-30 21:23, Scott Wood wrote:
>> On Apr 30, 2008, at 2:20 PM, Scott Wood wrote:
>> >On Wed, Apr 30, 2008 at 02:19:21PM -0500, Becky Bruce wrote:
>> >>I just noticed that the fec_8xx driver is not currently reachable via
>> >>menuconfig because it depends on 8XX instead of 8xx.
>> >[snip]
>> >>Since nobody has noticed this problem, I'm wondering if this driver
>> >>is still in (infrequent) use, or if it's been superseded and should
>> >>be removed, or if I'm just completely missing something with respect
>> >>to the use of "8XX" instead of "8xx".

Blame those developers who had the brilliant idea of using lowercase in
kconfig symbols (these things emit cosmic particles en masse!) :-)

arch/arm/mach-pxa/Kconfig:config PXA3xx

Re: drivers/net/fec_8xx config problem

[Vitaly Bordug]

On Wed, 30 Apr 2008 14:23:29 -0500
Scott Wood wrote:

> On Wed, Apr 30, 2008 at 02:24:19PM -0500, Becky Bruce wrote:
> > 
> > On Apr 30, 2008, at 2:20 PM, Scott Wood wrote:
> > >On Wed, Apr 30, 2008 at 02:19:21PM -0500, Becky Bruce wrote:
> > >>I just noticed that the fec_8xx driver is not currently reachable
> > >>via menuconfig because it depends on 8XX instead of 8xx.
> > >[snip]
> > >>Since nobody has noticed this problem, I'm wondering if this
> > >>driver is still in (infrequent) use, or if it's been superseded
> > >>and should be removed, or if I'm just completely missing
> > >>something with respect to the use of "8XX" instead of "8xx".
> > >
> > >It's been superseded by drivers/net/fs_enet.
> > 
> > Is there any reason we haven't removed it?
> 
> To keep arch/ppc/8xx_io company? :-)
> 
> > If not, I can push a patch to yank it.
> 
> I have no objection.

I am OK with this too. Should have been done long ago, but who likes janitorial stuff :)

-Vitaly