linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sean MacLennan <seanm@seanm.ca>
To: <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: WARNING: mutexes are preferred for single holder semaphores
Date: Mon, 5 May 2008 00:40:23 -0400	[thread overview]
Message-ID: <20080505004023.05603b93@lappy.seanm.ca> (raw)
In-Reply-To: <1209958719.21644.32.camel@pasglop>

On Mon, 05 May 2008 13:38:39 +1000
"Benjamin Herrenschmidt" <benh@kernel.crashing.org> wrote:

> Show us the code... It could be a bug in checkpatch or you using 
> the wrong functions somewhere ...

The change to DEFINE_MUTEX and changing up/down to
mutex_lock/mutex_unlock solved the problem.

The code is GPLed but not currently available on the net. It is
basically a little driver that registers a character device and
then passes out the minor numbers to the PIKA board drivers.

It was written to isolate all the character/sysfs code to one place
since we have five drivers, and many debug drivers, that use it.

If anybody is really interested, I can post it here. I doubt it will
ever be submitted to the mainline kernel however.

Cheers,
   Sean

  reply	other threads:[~2008-05-05  4:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-05  0:41 WARNING: mutexes are preferred for single holder semaphores Sean MacLennan
2008-05-05  1:06 ` Michael Ellerman
2008-05-05  1:31   ` Sean MacLennan
2008-05-05  2:13 ` Paul Mackerras
2008-05-05  6:01   ` Christoph Hellwig
2008-05-05  3:38 ` Benjamin Herrenschmidt
2008-05-05  4:40   ` Sean MacLennan [this message]
2008-05-07 14:36     ` All your drivers are belong to us [was WARNING: mutexes are preferred for single holder semaphores] Detlev Zundel
2008-05-07 21:42       ` All your drivers are belong to us [was WARNING: mutexes are preferredfor " Sean MacLennan
2008-05-08  0:49         ` Josh Boyer
2008-05-08  4:41           ` Sean MacLennan
2008-05-08 13:28           ` All your drivers are belong to us Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080505004023.05603b93@lappy.seanm.ca \
    --to=seanm@seanm.ca \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).