From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by ozlabs.org (Postfix) with SMTP id 19662DDE9F for ; Tue, 6 May 2008 18:19:15 +1000 (EST) Content-Type: text/plain; charset="iso-8859-1" Date: Tue, 06 May 2008 10:19:14 +0200 From: "Gerhard Pircher" In-Reply-To: <20080505185538.GA4906@polina.dev.rtsoft.ru> Message-ID: <20080506081914.269180@gmx.net> MIME-Version: 1.0 References: <20080505185538.GA4906@polina.dev.rtsoft.ru> Subject: Re: [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC To: Anton Vorontsov , galak@kernel.crashing.org Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , -------- Original-Nachricht -------- > Datum: Mon, 5 May 2008 22:55:38 +0400 > Von: Anton Vorontsov > An: Kumar Gala > CC: linuxppc-dev@ozlabs.org > Betreff: [PATCH 1/2] [POWERPC] rtc_cmos_setup: assign interrupts only if there is i8259 PIC > Sometimes (particularly on MPC8610HPCD) we want IRQ-less CMOS RTC for > the boards without (or disabled) i8259 PICs. > > We lookup the device tree for "chrp,iic" compatible devices, and if not > found we do not assign RTC IRQ. > > Signed-off-by: Anton Vorontsov > --- > arch/powerpc/sysdev/rtc_cmos_setup.c | 21 +++++++++++++++------ > 1 files changed, 15 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/sysdev/rtc_cmos_setup.c > b/arch/powerpc/sysdev/rtc_cmos_setup.c > index c09ddc0..e5d0bcb 100644 > --- a/arch/powerpc/sysdev/rtc_cmos_setup.c > +++ b/arch/powerpc/sysdev/rtc_cmos_setup.c > @@ -21,6 +21,7 @@ static int __init add_rtc(void) > struct device_node *np; > struct platform_device *pd; > struct resource res[2]; > + unsigned int num_res = 1; > int ret; > > memset(&res, 0, sizeof(res)); > @@ -41,14 +42,22 @@ static int __init add_rtc(void) > if (res[0].start != RTC_PORT(0)) > return -EINVAL; > > - /* Use a fixed interrupt value of 8 since on PPC if we are using this > - * its off an i8259 which we ensure has interrupt numbers 0..15. */ > - res[1].start = 8; > - res[1].end = 8; > - res[1].flags = IORESOURCE_IRQ; > + np = of_find_compatible_node(NULL, NULL, "chrp,iic"); Could you add a check for "pnpPNP,000" (PNP ID for i8259), as not all platforms use the CHRP names? Gerhard -- 249 Spiele für nur 1 Preis. Die GMX Spieleflatrate schon ab 9,90 Euro. Neu: Asterix bei den Olympischen Spielen: http://flat.games.gmx.de