From: Bryan O'Donoghue <bodonoghue@codehermit.ie>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Add support for Analogue & Micro ASP837E board
Date: Tue, 6 May 2008 11:30:55 +0100 [thread overview]
Message-ID: <20080506113055.499947e5@neuromancer.mindspace> (raw)
In-Reply-To: <20080506161110.02c2f974.sfr@canb.auug.org.au>
On Tue, 6 May 2008 16:11:10 +1000
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Bryan,
>
> On Tue, 6 May 2008 03:28:13 +0100 Bryan O'Donoghue <bodonoghue@codehermit.ie>
> wrote:
> >
> > +static void __init asp834x_init_IRQ(void)
> > +{
> > + struct device_node *np;
> > +
> > + np = of_find_node_by_type(NULL, "ipic");
> > + if (!np)
> > + return;
> > +
> > + ipic_init(np, 0);
>
> You need an "of_node_put(np)" here to drop the reference gained in
> "of_find_node_by_type".
>
> > +static struct of_device_id asp8347_ids[] = {
>
> Please make this __initdata.
>
Hey Stephen.
Thanks for spotting that. Will do.
Cheers,
Bryan
next prev parent reply other threads:[~2008-05-06 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-06 2:28 [PATCH] Add support for Analogue & Micro ASP837E board Bryan O'Donoghue
2008-05-06 6:11 ` Stephen Rothwell
2008-05-06 10:30 ` Bryan O'Donoghue [this message]
2008-05-06 13:37 ` Kumar Gala
2008-05-06 23:30 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080506113055.499947e5@neuromancer.mindspace \
--to=bodonoghue@codehermit.ie \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).