* [PATCH]: PPC_OF protect USB driver...
@ 2008-05-05 7:57 David Miller
2008-05-05 8:26 ` Benjamin Herrenschmidt
2008-05-09 5:27 ` Paul Mackerras
0 siblings, 2 replies; 4+ messages in thread
From: David Miller @ 2008-05-05 7:57 UTC (permalink / raw)
To: linuxppc-dev
This uses APIs that are not generic, or at least not part of
what Sparc provides yet.
So just PPC_OF this for now just like the EHCI_OF driver.
This fixes allmodconfig build errors on sparc.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 33b467a..1ef6df3 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -129,7 +129,7 @@ config USB_ISP1760_PCI
config USB_ISP1760_OF
bool "Support for the OF platform bus"
- depends on USB_ISP1760_HCD && OF
+ depends on USB_ISP1760_HCD && PPC_OF
---help---
Enables support for the device present on the PowerPC
OpenFirmware platform bus.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH]: PPC_OF protect USB driver...
2008-05-05 7:57 [PATCH]: PPC_OF protect USB driver David Miller
@ 2008-05-05 8:26 ` Benjamin Herrenschmidt
2008-05-09 5:27 ` Paul Mackerras
1 sibling, 0 replies; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2008-05-05 8:26 UTC (permalink / raw)
To: David Miller; +Cc: linuxppc-dev
On Mon, 2008-05-05 at 00:57 -0700, David Miller wrote:
> This uses APIs that are not generic, or at least not part of
> what Sparc provides yet.
>
> So just PPC_OF this for now just like the EHCI_OF driver.
>
> This fixes allmodconfig build errors on sparc.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
>
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 33b467a..1ef6df3 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -129,7 +129,7 @@ config USB_ISP1760_PCI
>
> config USB_ISP1760_OF
> bool "Support for the OF platform bus"
> - depends on USB_ISP1760_HCD && OF
> + depends on USB_ISP1760_HCD && PPC_OF
> ---help---
> Enables support for the device present on the PowerPC
> OpenFirmware platform bus.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH]: PPC_OF protect USB driver...
2008-05-05 7:57 [PATCH]: PPC_OF protect USB driver David Miller
2008-05-05 8:26 ` Benjamin Herrenschmidt
@ 2008-05-09 5:27 ` Paul Mackerras
2008-05-09 5:51 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Paul Mackerras @ 2008-05-09 5:27 UTC (permalink / raw)
To: David Miller; +Cc: linuxppc-dev
David Miller writes:
> This uses APIs that are not generic, or at least not part of
> what Sparc provides yet.
>
> So just PPC_OF this for now just like the EHCI_OF driver.
>
> This fixes allmodconfig build errors on sparc.
Are you going to send this to the USB maintainers, or are you going to
merge it to Linus, or do you want me to?
Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH]: PPC_OF protect USB driver...
2008-05-09 5:27 ` Paul Mackerras
@ 2008-05-09 5:51 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-05-09 5:51 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
From: Paul Mackerras <paulus@samba.org>
Date: Fri, 9 May 2008 15:27:37 +1000
> David Miller writes:
>
> > This uses APIs that are not generic, or at least not part of
> > what Sparc provides yet.
> >
> > So just PPC_OF this for now just like the EHCI_OF driver.
> >
> > This fixes allmodconfig build errors on sparc.
>
> Are you going to send this to the USB maintainers, or are you going to
> merge it to Linus, or do you want me to?
It is in Linus's tree after a sparc push I sent to him yesterday.
Thanks Paul.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-05-09 5:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-05 7:57 [PATCH]: PPC_OF protect USB driver David Miller
2008-05-05 8:26 ` Benjamin Herrenschmidt
2008-05-09 5:27 ` Paul Mackerras
2008-05-09 5:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).