From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <davem@davemloft.net>
Received: from sunset.davemloft.net (unknown [74.93.104.97])
	by ozlabs.org (Postfix) with ESMTP id A70D8DDFAD
	for <linuxppc-dev@ozlabs.org>; Thu, 15 May 2008 17:02:10 +1000 (EST)
Date: Thu, 15 May 2008 00:02:03 -0700 (PDT)
Message-Id: <20080515.000203.225783838.davem@davemloft.net>
To: benh@kernel.crashing.org
Subject: Re: PS3: Fix memory hotplug
From: David Miller <davem@davemloft.net>
In-Reply-To: <1210834289.8297.85.camel@pasglop>
References: <4829C07A.4040407@am.sony.com> <1210834125.8297.80.camel@pasglop>
	<1210834289.8297.85.camel@pasglop>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Wed, 14 May 2008 23:51:29 -0700

> 
> > Paul, any thoughts here ? Should we add a lock ? That would mean being
> > careful as the LMB stuff can be called very early, and spinlock wants
> > things like PACA and possibly lockdep to be around.. 
> 
> Actually, we call early_init_devtree(), which populates the LMB, after
> we initialize the PACA and lockdep, so it -should- be safe to add a
> spinlock.
> 
> Dave ? Any objection to adding a spinlock to the LMB code ?

No objections, just don't add any bugs. :-)