From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Olaf Hering" <olaf@aepfle.de>
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
Matt Carlson <mcarlson@broadcom.com>,
Michael Chan <mchan@broadcom.com>
Subject: Re: dead network on JS21 with tg3 driver after flowcontrol changes
Date: Thu, 15 May 2008 10:15:20 -0700 [thread overview]
Message-ID: <20080515171520.GA20953@localdomain> (raw)
In-Reply-To: <20080515121340.GA23033@aepfle.de>
If you were to start with the original file, does the following patch
fix the problem?
diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c
index 07b3f77..4c248d7 100644
--- a/drivers/net/tg3.c
+++ b/drivers/net/tg3.c
@@ -3168,8 +3168,7 @@ static int tg3_setup_fiber_mii_phy(struct tg3 *tp, int force_reset)
err |= tg3_readphy(tp, MII_BMCR, &bmcr);
if ((tp->link_config.autoneg == AUTONEG_ENABLE) && !force_reset &&
- (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT) &&
- tp->link_config.flowctrl == tp->link_config.active_flowctrl) {
+ (tp->tg3_flags2 & TG3_FLG2_PARALLEL_DETECT)) {
/* do nothing, just check for link up at the end */
} else if (tp->link_config.autoneg == AUTONEG_ENABLE) {
u32 adv, new_adv;
next prev parent reply other threads:[~2008-05-15 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 12:13 dead network on JS21 with tg3 driver after flowcontrol changes Olaf Hering
2008-05-15 15:10 ` Michael Chan
2008-05-15 15:49 ` Olaf Hering
2008-05-15 17:37 ` Michael Chan
2008-05-15 17:15 ` Matt Carlson [this message]
2008-05-15 19:51 ` Michael Chan
2008-05-16 8:13 ` Olaf Hering
2008-05-16 15:09 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515171520.GA20953@localdomain \
--to=mcarlson@broadcom.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).