From: David Miller <davem@davemloft.net>
To: geoffrey.levand@am.sony.com
Cc: paulus@samba.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: Re: [patch v2] LMB: Add basic spin locking to lmb
Date: Mon, 19 May 2008 19:22:15 -0700 (PDT) [thread overview]
Message-ID: <20080519.192215.193701293.davem@davemloft.net> (raw)
In-Reply-To: <48322191.6060909@am.sony.com>
From: Geoff Levand <geoffrey.levand@am.sony.com>
Date: Mon, 19 May 2008 17:55:45 -0700
> Add a spinlock to struct lmb to enforce concurrency in
> lmb_add(), lmb_remove(), lmb_analyze(), lmb_find(), and
> lmb_dump_all().
>
> This locking is needed for SMP systems that access the lmb structure
> during hot memory add and remove operations after secondary cpus
> have been started.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
> ---
>
> v2: o Add locking to lmb_find().
I'm not against this patch, but I'm pretty sure it's not
necessary. Isn't memory hotplug already synchronized at
a higher level?
If not, it should be.
next prev parent reply other threads:[~2008-05-20 2:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 16:23 PS3: Fix memory hotplug Geoff Levand
2008-05-15 6:48 ` Benjamin Herrenschmidt
2008-05-15 6:51 ` Benjamin Herrenschmidt
2008-05-15 7:02 ` David Miller
2008-05-20 0:40 ` [rfc] [patch] LMB: Add basic spin locking to lmb Geoff Levand
2008-05-20 0:55 ` [patch v2] " Geoff Levand
2008-05-20 2:22 ` David Miller [this message]
2008-05-20 2:32 ` Benjamin Herrenschmidt
2008-05-20 2:34 ` David Miller
2008-05-15 9:38 ` PS3: Fix memory hotplug Paul Mackerras
2008-05-21 18:31 ` Geoff Levand
2008-05-15 20:09 ` [patch v2] " Geoff Levand
2008-05-21 16:41 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519.192215.193701293.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).