From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v2] LMB: Add basic spin locking to lmb
Date: Mon, 19 May 2008 19:34:39 -0700 (PDT) [thread overview]
Message-ID: <20080519.193439.31663045.davem@davemloft.net> (raw)
In-Reply-To: <1211250778.8297.159.camel@pasglop>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 19 May 2008 22:32:58 -0400
> I think the core memory hotplug is... However, we used to not change the
> LMB when doing so (afaik, I'm travelling and not looking at the code
> right now). However, things like PS3 memory hotplug tries to keep LMB is
> sync for the sake of /dev/mem or similar and that happens before the
> memory is added to the core.
But if the memory hotplug is synchronized, so are changes to the LMB
tables.
And if there are LMB read side access concernes outside of the hotplug
event, ideally we should use the synchronization mechanism that
hotplug uses instead of adding a new one.
next prev parent reply other threads:[~2008-05-20 2:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 16:23 PS3: Fix memory hotplug Geoff Levand
2008-05-15 6:48 ` Benjamin Herrenschmidt
2008-05-15 6:51 ` Benjamin Herrenschmidt
2008-05-15 7:02 ` David Miller
2008-05-20 0:40 ` [rfc] [patch] LMB: Add basic spin locking to lmb Geoff Levand
2008-05-20 0:55 ` [patch v2] " Geoff Levand
2008-05-20 2:22 ` David Miller
2008-05-20 2:32 ` Benjamin Herrenschmidt
2008-05-20 2:34 ` David Miller [this message]
2008-05-15 9:38 ` PS3: Fix memory hotplug Paul Mackerras
2008-05-21 18:31 ` Geoff Levand
2008-05-15 20:09 ` [patch v2] " Geoff Levand
2008-05-21 16:41 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080519.193439.31663045.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).