From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 20 May 2008 15:10:54 +1000 From: David Gibson To: Kumar Gala Subject: Re: [PATCH 0/4] minor fixes for 2.6.26 Message-ID: <20080520051054.GN22279@yookeroo.seuss> References: <1211136296-4572-1-git-send-email-galak@kernel.crashing.org> <0B367446-4628-4633-BF66-A0007BD9A98B@kernel.crashing.org> <18482.2082.900892.368978@cargo.ozlabs.ibm.com> <119050FE-2BF4-4A45-8723-7A08EF38B290@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <119050FE-2BF4-4A45-8723-7A08EF38B290@kernel.crashing.org> Cc: linuxppc-dev@ozlabs.org, Paul Mackerras List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, May 19, 2008 at 11:52:31PM -0500, Kumar Gala wrote: > > On May 19, 2008, at 6:07 PM, Paul Mackerras wrote: > >> Kumar Gala writes: >> >>>> Kumar Gala (4): >>>> lmb: Fix compile warning >>>> [POWERPC] Remove generated files on make clean >> >> I think that adding zImage.* to clean-files is a bad idea, because we >> have zImage.lds.S, zImage.coff.lds.S and zImage.ps3.lds.S in >> arch/powerpc/boot that we don't want deleted. It would be OK for >> compiling with a separate object directory but would be bad for >> compiling in the source directory. > > We already had them in clean-files: > > clean-files := $(zlib) $(zlibheader) $(zliblinuxheader) \ > empty.c zImage zImage.coff.lds zImage.ps3.lds zImage.lds Not quite. Those are the zImage.lds files, Paul is talking about the zImage.lds.S files from which the former are generated. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson