From: Andrew Morton <akpm@linux-foundation.org>
To: benh@kernel.crashing.org
Cc: linux-arch@vger.kernel.org, linux-m32r@ml.linux-m32r.org,
LukeBrowning@us.ibm.com, takata@linux-m32r.org,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
paulus@samba.org
Subject: Re: [PATCH 1/2] Add thread_info_cache_init() to all archs
Date: Wed, 21 May 2008 13:52:30 -0700 [thread overview]
Message-ID: <20080521135230.69c04ab4.akpm@linux-foundation.org> (raw)
In-Reply-To: <1211399081.8297.234.camel@pasglop>
On Wed, 21 May 2008 15:44:41 -0400
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> On Wed, 2008-05-21 at 11:41 -0700, Andrew Morton wrote:
> >
> > yup, gcc bug. Discussed recently on lkml, "Subject: Re: huge gcc
> > 4.1.{0,1} __weak problem". I don't think anything ended up happening
> > about it though.
>
> Hrm... do you think we should work around ? ie. move the stubs to a
> separate .c file ?
>
istr that sticking an asm(""); in the weak function was a reliable
workaround. If we are going to to that it should be via
/* comment goes here */
#define gcc_screws_up_weak_stuff() asm("")
but that approach didn't seem very popular. It's a _bit_ fragile I
guess, but it's pretty easy to grep for missed workarounds.
next prev parent reply other threads:[~2008-05-21 21:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 3:22 [PATCH 1/2] Add thread_info_cache_init() to all archs Benjamin Herrenschmidt
2008-04-10 21:46 ` Benjamin Herrenschmidt
2008-04-14 0:19 ` Andrew Morton
2008-04-14 0:38 ` Benjamin Herrenschmidt
2008-04-14 2:13 ` Andrew Morton
2008-04-18 3:58 ` Benjamin Herrenschmidt
2008-04-18 4:19 ` Andrew Morton
2008-04-18 4:38 ` Michael Ellerman
2008-04-18 6:44 ` Benjamin Herrenschmidt
2008-05-21 17:56 ` Benjamin Herrenschmidt
2008-05-21 18:41 ` Andrew Morton
2008-05-21 19:06 ` Sam Ravnborg
2008-05-21 20:38 ` Benjamin Herrenschmidt
2008-05-21 19:44 ` Benjamin Herrenschmidt
2008-05-21 20:52 ` Andrew Morton [this message]
2008-04-18 4:21 ` Kyle McMartin
-- strict thread matches above, loose matches on Subject: below --
2008-04-10 23:36 Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080521135230.69c04ab4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=LukeBrowning@us.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m32r@ml.linux-m32r.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=takata@linux-m32r.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).