From: David Brownell <david-b@pacbell.net>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@ozlabs.org, fabrizio.garetto@gmail.com,
linux-kernel@vger.kernel.org,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration.
Date: Wed, 21 May 2008 17:17:13 -0700 [thread overview]
Message-ID: <200805211717.13206.david-b@pacbell.net> (raw)
In-Reply-To: <20080516193608.28030.34968.stgit@trillian.secretlab.ca>
On Friday 16 May 2008, Grant Likely wrote:
>
> This patch splits the allocation and registration portions of code out
> of spi_new_device() and creates three new functions; spi_alloc_device(),
> spi_register_device(), and spi_device_release().
I have no problem with the first two, but why the last?
If the devices are always allocated by spi_alloc_device() as
they should be -- probably through an intermediary -- the
only public function necessary for that cleanup should be
the existing spi_dev_put().
- Dave
next prev parent reply other threads:[~2008-05-22 3:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 19:35 [RFC PATCH 0/4] Describe SPI devices in the OF device tree and add mpc5200-spi driver Grant Likely
2008-05-16 19:36 ` [PATCH 1/4] spi: Change modalias from a pointer to a character array Grant Likely
2008-05-16 19:36 ` [PATCH 2/4] spi: split up spi_new_device() to allow two stage registration Grant Likely
2008-05-22 0:17 ` David Brownell [this message]
2008-05-24 6:43 ` Grant Likely
2008-05-24 6:54 ` Grant Likely
2008-06-30 4:08 ` David Brownell
2008-06-17 7:28 ` Grant Likely
2008-06-30 4:10 ` David Brownell
2008-05-16 19:36 ` [PATCH 3/4] spi: Add OF binding support for SPI busses Grant Likely
2008-05-16 20:47 ` Randy Dunlap
2008-05-16 20:51 ` Grant Likely
2008-05-16 22:03 ` Anton Vorontsov
2008-05-16 22:14 ` Grant Likely
2008-05-16 22:49 ` Anton Vorontsov
2008-05-17 5:02 ` Grant Likely
2008-05-22 1:16 ` David Brownell
2008-05-24 6:24 ` Grant Likely
2008-05-19 13:17 ` Guennadi Liakhovetski
2008-05-19 15:57 ` Grant Likely
2008-05-19 16:30 ` Guennadi Liakhovetski
2008-05-20 5:13 ` Grant Likely
2008-05-20 15:26 ` Guennadi Liakhovetski
2008-05-20 15:48 ` Grant Likely
2008-05-21 19:11 ` Segher Boessenkool
2008-05-21 19:33 ` Grant Likely
2008-05-23 2:26 ` [spi-devel-general] " David Brownell
2008-05-24 6:25 ` Grant Likely
2008-05-24 7:13 ` David Brownell
2008-05-19 17:09 ` Gary Jennejohn
2008-05-19 17:19 ` Anton Vorontsov
2008-05-20 12:26 ` Gary Jennejohn
2008-05-21 15:19 ` Anton Vorontsov
2008-05-23 2:05 ` David Brownell
2008-05-24 6:26 ` Grant Likely
2008-05-24 16:50 ` Grant Likely
2008-05-24 17:14 ` Jochen Friedrich
2008-05-24 17:33 ` Grant Likely
2008-05-24 17:45 ` David Brownell
2008-05-25 4:56 ` Grant Likely
2008-05-24 17:43 ` David Brownell
2008-05-16 19:36 ` [PATCH 4/4] [CSB] Add new mpc5200-spi (non-psc) device driver Grant Likely
2008-05-16 19:42 ` Grant Likely
2008-05-16 20:27 ` [RFC PATCH 0/4] Describe SPI devices in the OF device tree and add mpc5200-spi driver Jon Smirl
2008-05-16 20:48 ` Grant Likely
2008-05-16 21:25 ` Jon Smirl
2008-05-16 21:32 ` Grant Likely
2008-05-16 21:42 ` Jon Smirl
2008-05-16 21:58 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805211717.13206.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=fabrizio.garetto@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).