* [PATCH] rcupreempt: remove export of rcu_batches_completed_bh
@ 2008-05-22 18:18 Steven Rostedt
2008-05-23 14:14 ` Paul E. McKenney
2008-05-27 15:36 ` Thomas Gleixner
0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2008-05-22 18:18 UTC (permalink / raw)
To: LKML; +Cc: linuxppc-dev, Ingo Molnar, Paul E. McKenney, paulus
In rcupreempt, rcu_batches_completed_bh is defined as a static inline in
the header file. This does not need to be exported, and not only that,
this breaks my PPC build.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/rcupreempt.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-tip.git/kernel/rcupreempt.c
===================================================================
--- linux-tip.git.orig/kernel/rcupreempt.c 2008-05-22 11:12:30.000000000 -0700
+++ linux-tip.git/kernel/rcupreempt.c 2008-05-22 11:12:33.000000000 -0700
@@ -217,8 +217,6 @@ long rcu_batches_completed(void)
}
EXPORT_SYMBOL_GPL(rcu_batches_completed);
-EXPORT_SYMBOL_GPL(rcu_batches_completed_bh);
-
void __rcu_read_lock(void)
{
int idx;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rcupreempt: remove export of rcu_batches_completed_bh
2008-05-22 18:18 [PATCH] rcupreempt: remove export of rcu_batches_completed_bh Steven Rostedt
@ 2008-05-23 14:14 ` Paul E. McKenney
2008-05-27 15:36 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2008-05-23 14:14 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linuxppc-dev, Ingo Molnar, paulus, LKML
On Thu, May 22, 2008 at 02:18:17PM -0400, Steven Rostedt wrote:
>
> In rcupreempt, rcu_batches_completed_bh is defined as a static inline in
> the header file. This does not need to be exported, and not only that,
> this breaks my PPC build.
Good catch!!!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> ---
> kernel/rcupreempt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> Index: linux-tip.git/kernel/rcupreempt.c
> ===================================================================
> --- linux-tip.git.orig/kernel/rcupreempt.c 2008-05-22 11:12:30.000000000 -0700
> +++ linux-tip.git/kernel/rcupreempt.c 2008-05-22 11:12:33.000000000 -0700
> @@ -217,8 +217,6 @@ long rcu_batches_completed(void)
> }
> EXPORT_SYMBOL_GPL(rcu_batches_completed);
>
> -EXPORT_SYMBOL_GPL(rcu_batches_completed_bh);
> -
> void __rcu_read_lock(void)
> {
> int idx;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rcupreempt: remove export of rcu_batches_completed_bh
2008-05-22 18:18 [PATCH] rcupreempt: remove export of rcu_batches_completed_bh Steven Rostedt
2008-05-23 14:14 ` Paul E. McKenney
@ 2008-05-27 15:36 ` Thomas Gleixner
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Gleixner @ 2008-05-27 15:36 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linuxppc-dev, Ingo Molnar, Paul E. McKenney, paulus, LKML
On Thu, 22 May 2008, Steven Rostedt wrote:
> In rcupreempt, rcu_batches_completed_bh is defined as a static inline in
> the header file. This does not need to be exported, and not only that,
> this breaks my PPC build.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Applied, queued for Linus. Thanks
tglx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-27 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-22 18:18 [PATCH] rcupreempt: remove export of rcu_batches_completed_bh Steven Rostedt
2008-05-23 14:14 ` Paul E. McKenney
2008-05-27 15:36 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).