linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Loeliger <jdl@freescale.com>
Cc: linuxppc-dev@ozlabs.org
Subject: dtc: Remove some small bashisms from test scripts
Date: Thu, 29 May 2008 16:16:21 +1000	[thread overview]
Message-ID: <20080529061621.GA7220@yookeroo.seuss> (raw)

Some of the helper scripts used to run testcases contain some
constructs that are bashisms.  Or at least which don't work on dash,
the minimal shell used as /bin/sh on recent Ubuntu systems.

This patch removes these constructs so that the testsuite will pass
"out of the box" on systems where /bin/sh is dash.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Index: dtc/tests/dtc-checkfails.sh
===================================================================
--- dtc.orig/tests/dtc-checkfails.sh	2008-05-29 14:51:19.000000000 +1000
+++ dtc/tests/dtc-checkfails.sh	2008-05-29 16:12:14.000000000 +1000
@@ -1,6 +1,6 @@
 #! /bin/sh
 
-. tests.sh
+. ./tests.sh
 
 for x; do
     shift
Index: dtc/tests/dtc-fatal.sh
===================================================================
--- dtc.orig/tests/dtc-fatal.sh	2008-05-29 14:56:51.000000000 +1000
+++ dtc/tests/dtc-fatal.sh	2008-05-29 16:12:31.000000000 +1000
@@ -1,6 +1,6 @@
 #! /bin/sh
 
-. tests.sh
+. ./tests.sh
 
 verbose_run $VALGRIND "$DTC" -o/dev/null "$@"
 ret="$?"
Index: dtc/tests/tests.sh
===================================================================
--- dtc.orig/tests/tests.sh	2008-05-29 16:11:15.000000000 +1000
+++ dtc/tests/tests.sh	2008-05-29 16:11:21.000000000 +1000
@@ -23,7 +23,7 @@ verbose_run () {
 verbose_run_log () {
     LOG="$1"
     shift
-    "$@" &> "$LOG"
+    "$@" > "$LOG" 2>&1
     ret=$?
     if [ -z "$QUIET_TEST" ]; then
 	cat "$LOG" >&2

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

             reply	other threads:[~2008-05-29  6:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-29  6:16 David Gibson [this message]
2008-05-29 12:28 ` dtc: Remove some small bashisms from test scripts Segher Boessenkool
2008-05-29 13:19 ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080529061621.GA7220@yookeroo.seuss \
    --to=david@gibson.dropbear.id.au \
    --cc=jdl@freescale.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).