* [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage
@ 2008-05-30 3:39 Benjamin Herrenschmidt
2008-05-30 4:02 ` Jesse Barnes
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-05-30 3:39 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev, Jesse Barnes
When Greg "fixed" the sysfs usage of that driver a while back, he seem
to have introduced a bug where the quotes are added around the name of
our specific sysfs files, thus breaking the user space tool.
This fixes it. Tested DLPAR operations on a POWER6 machine successfully.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- linux-work.orig/drivers/pci/hotplug/rpadlpar_sysfs.c 2008-05-30 13:21:06.000000000 +1000
+++ linux-work/drivers/pci/hotplug/rpadlpar_sysfs.c 2008-05-30 13:21:58.000000000 +1000
@@ -18,8 +18,12 @@
#include "rpadlpar.h"
#define DLPAR_KOBJ_NAME "control"
-#define ADD_SLOT_ATTR_NAME "add_slot"
-#define REMOVE_SLOT_ATTR_NAME "remove_slot"
+
+/* Those two have no quotes because they are passed to __ATTR() which
+ * stringifies the argument (yuck !)
+ */
+#define ADD_SLOT_ATTR_NAME add_slot
+#define REMOVE_SLOT_ATTR_NAME remove_slot
#define MAX_DRC_NAME_LEN 64
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage
2008-05-30 3:39 [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage Benjamin Herrenschmidt
@ 2008-05-30 4:02 ` Jesse Barnes
2008-05-30 5:45 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2008-05-30 4:02 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: linuxppc-dev, Paul Mackerras
On Thursday, May 29, 2008 8:39 pm Benjamin Herrenschmidt wrote:
> When Greg "fixed" the sysfs usage of that driver a while back, he seem
> to have introduced a bug where the quotes are added around the name of
> our specific sysfs files, thus breaking the user space tool.
>
> This fixes it. Tested DLPAR operations on a POWER6 machine successfully.
Do you think this is important enough for 2.6.26?
Thanks,
Jesse
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage
2008-05-30 4:02 ` Jesse Barnes
@ 2008-05-30 5:45 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2008-05-30 5:45 UTC (permalink / raw)
To: Jesse Barnes; +Cc: linuxppc-dev, Paul Mackerras
On Thu, 2008-05-29 at 21:02 -0700, Jesse Barnes wrote:
> On Thursday, May 29, 2008 8:39 pm Benjamin Herrenschmidt wrote:
> > When Greg "fixed" the sysfs usage of that driver a while back, he seem
> > to have introduced a bug where the quotes are added around the name of
> > our specific sysfs files, thus breaking the user space tool.
> >
> > This fixes it. Tested DLPAR operations on a POWER6 machine successfully.
>
> Do you think this is important enough for 2.6.26?
Yes and .25 too in fact. I'll send it to -stable once it's upstream.
Cheers,
Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-30 5:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-30 3:39 [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage Benjamin Herrenschmidt
2008-05-30 4:02 ` Jesse Barnes
2008-05-30 5:45 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).