From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage
Date: Fri, 30 May 2008 13:39:12 +1000 [thread overview]
Message-ID: <20080530034134.E2D81DDEE1@ozlabs.org> (raw)
When Greg "fixed" the sysfs usage of that driver a while back, he seem
to have introduced a bug where the quotes are added around the name of
our specific sysfs files, thus breaking the user space tool.
This fixes it. Tested DLPAR operations on a POWER6 machine successfully.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
drivers/pci/hotplug/rpadlpar_sysfs.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- linux-work.orig/drivers/pci/hotplug/rpadlpar_sysfs.c 2008-05-30 13:21:06.000000000 +1000
+++ linux-work/drivers/pci/hotplug/rpadlpar_sysfs.c 2008-05-30 13:21:58.000000000 +1000
@@ -18,8 +18,12 @@
#include "rpadlpar.h"
#define DLPAR_KOBJ_NAME "control"
-#define ADD_SLOT_ATTR_NAME "add_slot"
-#define REMOVE_SLOT_ATTR_NAME "remove_slot"
+
+/* Those two have no quotes because they are passed to __ATTR() which
+ * stringifies the argument (yuck !)
+ */
+#define ADD_SLOT_ATTR_NAME add_slot
+#define REMOVE_SLOT_ATTR_NAME remove_slot
#define MAX_DRC_NAME_LEN 64
next reply other threads:[~2008-05-30 3:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 3:39 Benjamin Herrenschmidt [this message]
2008-05-30 4:02 ` [PATCH] [POWERPC] Fix rpadlpar pci hotplug driver sysfs usage Jesse Barnes
2008-05-30 5:45 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080530034134.E2D81DDEE1@ozlabs.org \
--to=benh@kernel.crashing.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).