From: Nathan Lynch <ntl@pobox.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: ppc-dev list <linuxppc-dev@ozlabs.org>,
Yoder Stuart <stuart.yoder@freescale.com>
Subject: Re: [PATCH] [POWERPC] 85xx: Add next-level-cache property
Date: Mon, 2 Jun 2008 16:26:32 -0500 [thread overview]
Message-ID: <20080602212632.GA7475@localdomain> (raw)
In-Reply-To: <fe9c3824f2fd9c5013ae3eb037a017e9@kernel.crashing.org>
Segher Boessenkool wrote:
>>>
>>> The PowerPC binding defines an "l2-cache" property for this (it
>>> points from CPU node to L2 cache node, from L2 cache node to L3
>>> cache node, from L3 cache node to L4 cache node, etc.)
>>
>> So looking at the PPC binding its not terrible clear about "l3-cache"
>> being a valid property.
>
> It isn't. The property is called "l2-cache" at every level.
>
>> I believe the discussion w/ePAPR was to create something a bit more
>> generic and clarify/update the PPC binding.
>
> Nasty. Sure, "l2-cache" isn't the nicest name to point to deeper
> cache levels, but introducing a new property with (substantially)
> the same semantics is worse.
The semantics appear to be identical, even.
> There really shouldn't be a new property name until new functionality
> is introduced. For example, it could allow to describe more than one
> cache at each level (the current binding already allows more than one
> parent for each cache, but only one child; and cache hierarchies like
> that actually exist).
>
>> I'm going to stick with the new binding as we don't use this linking
>> currently.
>
> Dunno what's the best thing to do here. If you don't need the
> functionality yet, it might be best to postpone putting either
> property in there. Sigh, what a mess.
Does existing practice count for anything? IBM pseries firmware uses
the l2-cache property as described in the PowerPC binding.
next prev parent reply other threads:[~2008-06-02 21:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-30 20:43 [PATCH] [POWERPC] Cleanup mpic nodes in .dts Kumar Gala
2008-05-30 20:43 ` [PATCH] [POWERPC] 85xx: Add next-level-cache property Kumar Gala
2008-05-30 21:49 ` Segher Boessenkool
2008-06-02 16:15 ` Kumar Gala
2008-06-02 19:43 ` Kumar Gala
2008-06-02 21:06 ` Segher Boessenkool
2008-06-02 21:26 ` Nathan Lynch [this message]
2008-06-02 23:01 ` Kumar Gala
2008-05-30 21:42 ` [PATCH] [POWERPC] Cleanup mpic nodes in .dts Segher Boessenkool
2008-06-02 16:19 ` Kumar Gala
2008-06-02 16:32 ` Segher Boessenkool
2008-06-02 23:07 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080602212632.GA7475@localdomain \
--to=ntl@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=segher@kernel.crashing.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).