From: Stefan Roese <sr@denx.de>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: Scott Wood <scottwood@freescale.com>,
linuxppc-dev@ozlabs.org, Jean Delvare <khali@linux-fr.org>,
Timur Tabi <timur@freescale.com>
Subject: Re: "cell-index" vs. "index" vs. no index in I2C device nodes
Date: Thu, 5 Jun 2008 08:22:00 +0200 [thread overview]
Message-ID: <200806050822.00797.sr@denx.de> (raw)
In-Reply-To: <20080604231641.786bb2dd@lappy.seanm.ca>
On Thursday 05 June 2008, Sean MacLennan wrote:
> On Wed, 4 Jun 2008 22:05:55 -0500
>
> Josh Boyer <jwboyer@linux.vnet.ibm.com> wrote:
> > I'm not proposing we remove that. I'm just proposing that it can be
> > derived from something other than an "index" property. Fill it in
> > using a static integer that gets incremented for each new device
> > found. It's not like we have an indeterminate probe order, or these
> > IIC macros can be hot-plugged.
>
> That's how it used to work by default. It was decided to drop that and
> enforce an index. The following is a quote from Jean Delvare from a
I added Jean to CC now.
> post from 8/2/16 4:31:
> > I don't like this static index thing much. Can't you just make the
> > "index" OF property mandatory? Mixing ways to number things can become
> > very confusing. In particular as you are using dev->idx later to call
> > i2c_add_numbered_adapter(), the caller is really supposed to know what
> > they are doing with the bus numbers.
>
> Maybe it is time to remove the index, or maybe we should go back to
> using both a static and the index. But at the time we decided to enforce
> an index.
So what should we do now? Currently I2C doesn't work at all on 4xx since the
driver expects the "index" property and no dts sets this property. Personally
I would like to move to using cell-index here, since this seems to be more
common. But I could also life with removing the index property and using
the "static index" if this is preferred and/or acceptable.
Please advise. Thanks.
Best regards,
Stefan
next prev parent reply other threads:[~2008-06-05 6:28 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 15:06 "cell-index" vs. "index" vs. no index in I2C device nodes Stefan Roese
2008-06-04 15:24 ` Timur Tabi
2008-06-04 15:43 ` Scott Wood
2008-06-05 2:19 ` Josh Boyer
2008-06-05 2:41 ` David Gibson
2008-06-06 2:40 ` Segher Boessenkool
2008-06-06 3:37 ` David Gibson
2008-06-07 0:30 ` Segher Boessenkool
2008-06-06 4:07 ` Grant Likely
2008-06-06 4:29 ` Sean MacLennan
2008-06-05 2:54 ` Sean MacLennan
2008-06-05 3:05 ` Josh Boyer
2008-06-05 3:16 ` Sean MacLennan
2008-06-05 6:22 ` Stefan Roese [this message]
2008-06-05 7:48 ` Jean Delvare
2008-06-05 8:45 ` Stefan Roese
2008-06-05 10:57 ` David Gibson
2008-06-05 11:52 ` Josh Boyer
2008-06-05 15:18 ` Timur Tabi
2008-06-05 22:47 ` David Gibson
2008-06-06 4:17 ` Benjamin Herrenschmidt
2008-06-06 4:16 ` Benjamin Herrenschmidt
2008-06-06 6:21 ` Jean Delvare
2008-06-06 7:47 ` Grant Likely
2008-06-06 8:45 ` Benjamin Herrenschmidt
2008-06-05 15:17 ` Timur Tabi
2008-06-05 15:44 ` Jochen Friedrich
2008-06-05 15:50 ` Timur Tabi
2008-06-05 16:10 ` Grant Likely
2008-06-05 16:18 ` Timur Tabi
2008-06-05 16:22 ` Jochen Friedrich
2008-06-05 16:30 ` Grant Likely
2008-06-05 16:40 ` Timur Tabi
2008-06-05 22:46 ` David Gibson
2008-06-05 16:35 ` Grant Likely
2008-06-05 23:59 ` Josh Boyer
2008-06-07 0:24 ` Segher Boessenkool
2008-06-05 21:37 ` Sean MacLennan
2008-06-05 23:48 ` Josh Boyer
2008-06-05 15:13 ` Timur Tabi
2008-06-05 15:39 ` Grant Likely
2008-06-05 15:43 ` Timur Tabi
2008-06-05 15:52 ` Segher Boessenkool
2008-06-05 16:09 ` Timur Tabi
2008-06-05 16:27 ` Scott Wood
2008-06-05 17:52 ` Timur Tabi
2008-06-05 18:04 ` Scott Wood
2008-06-05 16:00 ` Grant Likely
2008-06-05 16:13 ` Timur Tabi
2008-06-05 16:21 ` Josh Boyer
2008-06-05 16:25 ` Timur Tabi
2008-06-05 16:37 ` Grant Likely
2008-06-05 18:27 ` Josh Boyer
2008-06-05 18:35 ` Timur Tabi
2008-06-05 18:40 ` Josh Boyer
2008-06-05 18:46 ` Grant Likely
2008-06-05 18:56 ` Josh Boyer
2008-06-05 19:14 ` Grant Likely
2008-06-05 19:15 ` Josh Boyer
2008-06-05 19:16 ` Timur Tabi
2008-06-05 21:31 ` Segher Boessenkool
2008-06-05 22:56 ` David Gibson
2008-06-06 13:09 ` Timur Tabi
2008-06-06 13:42 ` Stefan Roese
2008-06-05 22:45 ` Sean MacLennan
2008-06-06 4:20 ` Benjamin Herrenschmidt
2008-06-25 21:46 ` Timur Tabi
2008-06-27 16:48 ` Jochen Friedrich
2008-06-05 15:46 ` Segher Boessenkool
2008-06-05 15:52 ` Jochen Friedrich
2008-06-05 15:53 ` Grant Likely
2008-06-06 4:19 ` Benjamin Herrenschmidt
2008-06-06 4:14 ` Benjamin Herrenschmidt
2008-06-06 4:13 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806050822.00797.sr@denx.de \
--to=sr@denx.de \
--cc=khali@linux-fr.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
--cc=smaclennan@pikatech.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).