From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.179]) by ozlabs.org (Postfix) with ESMTP id B183BDDEEF for ; Mon, 9 Jun 2008 14:49:41 +1000 (EST) From: Stefan Roese To: Jean Delvare Subject: Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc Date: Mon, 9 Jun 2008 06:48:24 +0200 References: <1212653453-26093-1-git-send-email-sr@denx.de> <20080608144843.58857324@hyperion.delvare> In-Reply-To: <20080608144843.58857324@hyperion.delvare> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Message-Id: <200806090648.24339.sr@denx.de> Cc: linuxppc-dev@ozlabs.org, i2c@lm-sensors.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Jean, On Sunday 08 June 2008, Jean Delvare wrote: > > This patch enables the IBM I2C driver for all PPC4xx variants by adding > > "ibm,iic" to the compatible list. This way all currently available > > arch/powerpc 4xx ports can make use of this driver without any changes. > > Additionally all "other" compatible entries are removed since they are > > not needed anymore. > > > > Currently all 4xx PPC's have the same compatible I2C macro. If at some > > time an incompatibility is detected we can take care of this with an > > additional property. > > > > Signed-off-by: Stefan Roese > > --- > > drivers/i2c/busses/i2c-ibm_iic.c | 6 +----- > > 1 files changed, 1 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-ibm_iic.c > > b/drivers/i2c/busses/i2c-ibm_iic.c index 3a364a7..ed73801 100644 > > --- a/drivers/i2c/busses/i2c-ibm_iic.c > > +++ b/drivers/i2c/busses/i2c-ibm_iic.c > > @@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device > > *ofdev) } > > > > static const struct of_device_id ibm_iic_match[] = { > > - { .compatible = "ibm,iic-405ex", }, > > - { .compatible = "ibm,iic-405gp", }, > > - { .compatible = "ibm,iic-440gp", }, > > - { .compatible = "ibm,iic-440gpx", }, > > - { .compatible = "ibm,iic-440grx", }, > > + { .compatible = "ibm,iic", }, > > {} > > }; > > OK, I can take this in my tree, unless it depends on arch-specific > patches which have not hit mainline yet. No, this doesn't depend on other pathes. > I guess this is 2.6.27 > material? Yes. No real hurry here. Thanks. Best regards, Stefan