From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Julia Lawall <julia@diku.dk>
Cc: linuxppc-dev@ozlabs.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] drivers/macintosh/smu.c: add missing of_node_put
Date: Mon, 9 Jun 2008 23:32:01 +1000 [thread overview]
Message-ID: <20080609233201.fc638cc7.sfr@canb.auug.org.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0806091521390.16009@ask.diku.dk>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
Hi Julia,
On Mon, 9 Jun 2008 15:22:53 +0200 (CEST) Julia Lawall <julia@diku.dk> wrote:
>
> > However, the error handling in that routine (smu_init) needs much more
> > work.
>
> Indeed, the smu = NULL at the end of the function seems a bit brutal - a
> lot of allocated data ends up not getting freed. I can try to do
> something about it. Did you see something else?
There are paths to fail: where you would need to of_node_put smu->db_node or
smu->msg_node (or both) and undo the smu->db_buf ioremap.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2008-06-09 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 12:20 [PATCH 2/4] drivers/macintosh/smu.c: add missing of_node_put Julia Lawall
2008-06-09 13:07 ` Stephen Rothwell
2008-06-09 13:22 ` Julia Lawall
2008-06-09 13:32 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609233201.fc638cc7.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox