linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>, Roland Dreier <rolandd@cisco.com>
Cc: TKLEIN@de.ibm.com, THEMANN@de.ibm.com, fenkes@de.ibm.com,
	OF-EWG <ewg@lists.openfabrics.org>,
	LKML <linux-kernel@vger.kernel.org>,
	LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
	raisch@de.ibm.com, general@lists.openfabrics.org
Subject: Re: [PATCH 0/2] Prevent loss of interrupts in IB/ehca
Date: Tue, 10 Jun 2008 10:21:26 +0200	[thread overview]
Message-ID: <200806101021.28795.ossrosch@linux.vnet.ibm.com> (raw)
In-Reply-To: <18509.44672.668946.207110@cargo.ozlabs.ibm.com>

On Tuesday 10 June 2008 00:28:16 Paul Mackerras wrote:
> Stefan Roscher writes:
> 
> > This patchset contains two changes for IB/ehca and ibmebus.
> > 
> > The first patch enables ibmebus_request_irq() to optionally return the 
> > IRQ number, which is used by the second patch to trigger EOI in case of 
> > lost interrupts.
> 
> At first sight it seems like a very bad idea for a driver to be poking
> into the internals of the interrupt subsystem like this.  Under what
> circumstances do interrupts get lost, and why does doing an extra EOI
> like this fix the problem?
> 
> Paul.
> 

The processing of events with a timer controlled polling is not the "typical"
way how you should handle adapter events.
During corner case testing, we noticed that some versions of ehca 
do not properly transition to interrupt done in special load situations.
This can be resolved by periodically triggering EOI through H_EOI, 
if eqes are pending.
Hope this clarifys the backround of the patch.

Is there a better way to initiate this type of EOI in a non-irq case?

regards Stefan R. and Christoph R.

  reply	other threads:[~2008-06-10  8:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-09 15:42 [PATCH 0/2] Prevent loss of interrupts in IB/ehca Stefan Roscher
2008-06-09 22:28 ` Paul Mackerras
2008-06-10  8:21   ` Stefan Roscher [this message]
2008-06-10  9:21     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200806101021.28795.ossrosch@linux.vnet.ibm.com \
    --to=ossrosch@linux.vnet.ibm.com \
    --cc=THEMANN@de.ibm.com \
    --cc=TKLEIN@de.ibm.com \
    --cc=ewg@lists.openfabrics.org \
    --cc=fenkes@de.ibm.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=raisch@de.ibm.com \
    --cc=rolandd@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).