Re: [PATCH 4/7] [POWERPC] QE: implement support for the GPIO LIB API

[Anton Vorontsov <avorontsov@ru.mvista.com>]

On Tue, Jun 10, 2008 at 11:15:08AM -0500, Kumar Gala wrote:
>
> On May 19, 2008, at 12:47 PM, Anton Vorontsov wrote:
>
>> This is needed to access QE GPIOs via Linux GPIO API.
>>
>> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
>> Acked-By: Timur Tabi <timur@freescale.com>
>> ---
>> Documentation/powerpc/booting-without-of.txt |   27 +++++
>> arch/powerpc/sysdev/qe_lib/Kconfig           |    9 ++
>> arch/powerpc/sysdev/qe_lib/Makefile          |    1 +
>> arch/powerpc/sysdev/qe_lib/gpio.c            |  146 +++++++++++++++++ 
>> +++++++++
>> include/asm-powerpc/qe.h                     |    3 +
>> 5 files changed, 186 insertions(+), 0 deletions(-)
>> create mode 100644 arch/powerpc/sysdev/qe_lib/gpio.c
>
> applied.

I've just rebased on the pushed out powerpc-next branch, and noticed
that you merged this patch from the old series.

The difference is in absence of arch_initcall() for QE GPIOs
initialization, i.e. in this version boards should explicitly call
qe_add_gpiochips(). So.. was this done deliberately? Or should I send
you an update?

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2