[PATCH] ibm_newemac: select CRC32 in Kconfig

[PATCH] ibm_newemac: select CRC32 in Kconfig

[Josh Boyer]

The ibm_newemac driver requires ether_crc to be defined.  Apparently it is
possible to generate a .config without CONFIG_CRC32 set which causes the
following link errors if IBM_NEW_EMAC is selected:

  LD      .tmp_vmlinux1
drivers/built-in.o: In function `emac_hash_mc':
core.c:(.text+0x2f524): undefined reference to `crc32_le'
core.c:(.text+0x2f528): undefined reference to `bitrev32'
make: *** [.tmp_vmlinux1] Error 1

This patch has IBM_NEW_EMAC select CRC32 so we don't hit this error.

Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
---
 drivers/net/ibm_newemac/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ibm_newemac/Kconfig b/drivers/net/ibm_newemac/Kconfig
index 0d3e738..70a3272 100644
--- a/drivers/net/ibm_newemac/Kconfig
+++ b/drivers/net/ibm_newemac/Kconfig
@@ -1,6 +1,7 @@
 config IBM_NEW_EMAC
 	tristate "IBM EMAC Ethernet support"
 	depends on PPC_DCR && PPC_MERGE
+	select CRC32
 	help
 	  This driver supports the IBM EMAC family of Ethernet controllers
 	  typically found on 4xx embedded PowerPC chips, but also on the
-- 
1.5.4.3

Re: [PATCH] ibm_newemac: select CRC32 in Kconfig

[Jeff Garzik]

Josh Boyer wrote:
> The ibm_newemac driver requires ether_crc to be defined.  Apparently it is
> possible to generate a .config without CONFIG_CRC32 set which causes the
> following link errors if IBM_NEW_EMAC is selected:
> 
>   LD      .tmp_vmlinux1
> drivers/built-in.o: In function `emac_hash_mc':
> core.c:(.text+0x2f524): undefined reference to `crc32_le'
> core.c:(.text+0x2f528): undefined reference to `bitrev32'
> make: *** [.tmp_vmlinux1] Error 1
> 
> This patch has IBM_NEW_EMAC select CRC32 so we don't hit this error.
> 
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
> ---
>  drivers/net/ibm_newemac/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

applied