From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sam@ravnborg.org>
Received: from pasmtpA.tele.dk (pasmtpa.tele.dk [80.160.77.114])
	by ozlabs.org (Postfix) with ESMTP id 4D44FDDE00
	for <linuxppc-dev@ozlabs.org>; Wed, 18 Jun 2008 15:00:12 +1000 (EST)
Date: Wed, 18 Jun 2008 07:00:53 +0200
From: Sam Ravnborg <sam@ravnborg.org>
To: Trent Piepho <tpiepho@freescale.com>
Subject: Re: [PATCH] [Rev2] MPC5121 FEC support
Message-ID: <20080618050053.GA19359@uranus.ravnborg.org>
References: <1213729717-26688-1-git-send-email-jrigby@freescale.com>
	<48581188.90102@freescale.com>
	<20080617195739.GB13147@uranus.ravnborg.org>
	<485818AA.8090701@freescale.com>
	<20080617210055.GA13468@uranus.ravnborg.org>
	<485828B0.4010101@freescale.com>
	<Pine.LNX.4.64.0806171648300.7584@t2.domain.actdsltmp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <Pine.LNX.4.64.0806171648300.7584@t2.domain.actdsltmp>
Cc: Scott Wood <scottwood@freescale.com>, linuxppc-dev@ozlabs.org,
	jeff@garzik.org, John Rigby <jrigby@freescale.com>, netdev@vger.kernel.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>

> >
> >I'm not sure I understand what you're looking for, but I don't see 
> >anything wrong with something like this (apart from missing help text):
> >
> >config FS_ENET
> >	 bool
> >	 select MII
> >	 select PHYLIB
> >
> >config FS_ENET_HAS_SCC
> >	 bool "Freescale CPM SCC Ethernet"
> >	 depends on CPM1 || CPM2
> >	 select FS_ENET
> 
> What prevents me from turning on FS_ENET_HAS_SCC without MII or PHYLIB?
Nothing.
But if set FS_ENET_HAS_SCC to 'y' then kconfig will select FS_ENET
which again will select MII and PHYLIB.

	Sam