From: Scott Wood <scottwood@freescale.com>
To: John Rigby <jrigby@freescale.com>
Cc: linuxppc-dev@ozlabs.org, Sam Ravnborg <sam@ravnborg.org>,
jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] fs_enet: fix checkpatch.pl problems
Date: Wed, 18 Jun 2008 10:50:36 -0500 [thread overview]
Message-ID: <20080618155036.GB3887@loki.buserror.net> (raw)
In-Reply-To: <1213743794-3537-2-git-send-email-jrigby@freescale.com>
On Tue, Jun 17, 2008 at 05:03:13PM -0600, John Rigby wrote:
> static int __devinit find_phy(struct device_node *np,
> - struct fs_platform_info *fpi)
> + struct fs_platform_info *fpi)
Please don't make this sort of change. Spaces were used deliberately,
because it's alignment rather than indentation, and using tabs would make
things be unaligned with tab sizes other than 8, and (as can be seen above)
in patches.
Unfortunately, it's non-trivial to make checkpatch tell the difference
between the two (it would need to parse the language rather than do a simple
regex).
-Scott
prev parent reply other threads:[~2008-06-18 15:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 23:03 [PATCH 0/2] Add MPC5121 FEC suppport John Rigby
2008-06-17 23:03 ` [PATCH 1/2] fs_enet: fix checkpatch.pl problems John Rigby
2008-06-17 23:03 ` [PATCH 2/2] fs_enet: add MPC5121 FEC support John Rigby
2008-06-18 3:54 ` [PATCH 1/2] fs_enet: fix checkpatch.pl problems Jeff Garzik
2008-06-18 4:12 ` John Rigby
2008-06-18 15:07 ` Kumar Gala
2008-06-18 5:20 ` Grant Likely
2008-06-18 13:29 ` John Rigby
2008-06-18 15:50 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080618155036.GB3887@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=jeff@garzik.org \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).