Re: [PATCH 2/2] fs_enet: MDIO on GPIO support

[Laurent Pinchart <laurentp@cse-semaphore.com>]

[-- Attachment #1: Type: text/plain, Size: 1665 bytes --]

Hi Scott,

On Monday 16 June 2008 18:34, Scott Wood wrote:
> On Mon, Jun 16, 2008 at 10:57:02AM +0200, Laurent Pinchart wrote:
> > On Monday 26 May 2008 11:53, Laurent Pinchart wrote:
> > > Port the fs_enet driver to support the MDIO on GPIO driver for PHY
> > > access in addition to the mii-bitbang driver.
> > 
> > Now that 1/2 has been applied by Jeff, could this one make it to 
> > powerpc-next ?
> 
> This patch should probably go through Jeff as well...

Jeff, what's your opinion on this ?

> Acked-by: Scott Wood <scottwood@freescale.com>
> 
> > > -	data = of_get_property(phynode, "reg", &len);
> > > -	if (!data || len != 4)
> > > -		goto out_put_mdio;
> > > +	bus_id = of_get_gpio(mdionode, 0);
> > > +	if (bus_id < 0) {
> > > +		struct resource res;
> > > +		ret = of_address_to_resource(mdionode, 0, &res);
> > > +		if (ret)
> > > +			goto out_put_mdio;
> > > +		bus_id = res.start;
> > > +	}
> > >  
> > > -	snprintf(fpi->bus_id, 16, "%x:%02x", res.start, *data);
> > > +	snprintf(fpi->bus_id, 16, "%x:%02x", bus_id, *data);
> 
> It'd be nice if this sort of thing could be moved to phylib, so the latter
> could simply be passed a device node (in addition to current mechanisms for
> the benefit of unfortunate device-tree-less architectures).

Adding a phy_connect_of that would move the above logic to phy_device.c 
shouldn't be too difficult. Would that be enough ? The mdio bus code would 
still use the bus id to identify phy devices in mdiobus_register.

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]