linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Lynch <ntl@pobox.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linuxppc-dev@ozlabs.org, Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>,
	linux-kernel@vger.kernel.org, Anton Blanchard <anton@samba.org>
Subject: Re: [RFC/PATCH 0/3] sched: allow arch override of cpu power
Date: Thu, 19 Jun 2008 12:09:45 -0500	[thread overview]
Message-ID: <20080619170945.GB9594@localdomain> (raw)
In-Reply-To: <20080619095048.GD15228@elte.hu>

Ingo Molnar wrote:
> 
> * Nathan Lynch <ntl@pobox.com> wrote:
> > So it would be nice to have the scheduler slightly prefer primary 
> > threads on POWER6 machines.  These patches, which allow the 
> > architecture to override the scheduler's CPU "power" calculation, are 
> > one possible approach, but I'm open to others.  Please note: these 
> > seemed to have the desired effect on 2.6.25-rc kernels (2-3% 
> > improvement in a kernbench-like make -j <nr_cores>), but I'm not 
> > seeing this improvement with 2.6.26-rc kernels for some reason I am 
> > still trying to track down.
> 
> ok, i guess that discrepancy has to be tracked down before we can think 
> about these patches - but the principle is OK.

Great.  I'll keep trying to figure out what's going on there.


> One problem is that the whole cpu-power balancing code in sched.c is a 
> bit ... unclear and under-documented. So any change to this area should 
> begin at documenting the basics: what do the units mean exactly, how are 
> they used in balancing and what is the desired effect.
>
> I'd not be surprised if there were a few buglets in this area, SMT is 
> not at the forefront of testing at the moment. There's nothing 
> spectacularly broken in it (i have a HT machine myself), but the 
> concepts have bitrotten a bit. Patches - even if they just add comments 
> - are welcome :-)

Okay, I'll have a look.  Thanks Ingo.

  reply	other threads:[~2008-06-19 17:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19  0:29 [RFC/PATCH 0/3] sched: allow arch override of cpu power Nathan Lynch
2008-06-19  0:29 ` [RFC/PATCH 1/3] sched: support arch override of sched_group " Nathan Lynch
2008-06-19  0:29 ` [RFC/PATCH 2/3] add cpu_power to machdep_calls, override SD_SIBLING_INIT Nathan Lynch
2008-06-19  0:29 ` [RFC/PATCH 3/3] adjust cpu power for secondary threads on POWER6 Nathan Lynch
2008-06-19  2:58   ` Olof Johansson
2008-06-19  3:03     ` Olof Johansson
2008-06-19  9:50 ` [RFC/PATCH 0/3] sched: allow arch override of cpu power Ingo Molnar
2008-06-19 17:09   ` Nathan Lynch [this message]
2008-06-26 19:49 ` Breno Leitao
2008-06-27 14:23   ` Nathan Lynch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080619170945.GB9594@localdomain \
    --to=ntl@pobox.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).