From: Robert Jennings <rcj@linux.vnet.ibm.com>
To: paulus@samba.org
Cc: Brian King <brking@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org,
David Darrington <ddarring@linux.vnet.ibm.com>
Subject: [PATCH 01/18 v2] powerpc: Remove extraneous error reporting for hcall failures in lparcfg
Date: Wed, 25 Jun 2008 15:14:18 -0500 [thread overview]
Message-ID: <20080625201417.GC17020@linux.vnet.ibm.com> (raw)
In-Reply-To: <20080625201202.GB17020@linux.vnet.ibm.com>
=46rom: Nathan Fontenot <nfont@austin.ibm.com>
Remove the extraneous error reporting used when a hcall made from lparcfg f=
ails.
Signed-off-by: Nathan Fontenot <nfont@austin.ibm.com>
Signed-off-by: Robert Jennings <rcj@linux.vnet.ibm.com>
---
arch/powerpc/kernel/lparcfg.c | 32 --------------------------------
1 file changed, 32 deletions(-)
Index: b/arch/powerpc/kernel/lparcfg.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- a/arch/powerpc/kernel/lparcfg.c
+++ b/arch/powerpc/kernel/lparcfg.c
@@ -129,33 +129,6 @@ static int iseries_lparcfg_data(struct s
/*
* Methods used to fetch LPAR data when running on a pSeries platform.
*/
-static void log_plpar_hcall_return(unsigned long rc, char *tag)
-{
- switch(rc) {
- case 0:
- return;
- case H_HARDWARE:
- printk(KERN_INFO "plpar-hcall (%s) "
- "Hardware fault\n", tag);
- return;
- case H_FUNCTION:
- printk(KERN_INFO "plpar-hcall (%s) "
- "Function not allowed\n", tag);
- return;
- case H_AUTHORITY:
- printk(KERN_INFO "plpar-hcall (%s) "
- "Not authorized to this function\n", tag);
- return;
- case H_PARAMETER:
- printk(KERN_INFO "plpar-hcall (%s) "
- "Bad parameter(s)\n",tag);
- return;
- default:
- printk(KERN_INFO "plpar-hcall (%s) "
- "Unexpected rc(0x%lx)\n", tag, rc);
- }
-}
-
/*
* H_GET_PPP hcall returns info in 4 parms.
* entitled_capacity,unallocated_capacity,
@@ -191,8 +164,6 @@ static unsigned int h_get_ppp(unsigned l
*aggregation =3D retbuf[2];
*resource =3D retbuf[3];
=20
- log_plpar_hcall_return(rc, "H_GET_PPP");
-
return rc;
}
=20
@@ -205,9 +176,6 @@ static void h_pic(unsigned long *pool_id
=20
*pool_idle_time =3D retbuf[0];
*num_procs =3D retbuf[1];
-
- if (rc !=3D H_AUTHORITY)
- log_plpar_hcall_return(rc, "H_PIC");
}
=20
#define SPLPAR_CHARACTERISTICS_TOKEN 20
next prev parent reply other threads:[~2008-06-25 20:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 20:12 [PATCH 00/18 v2] powerpc: pSeries Cooperative Memory Overcommitment support Robert Jennings
2008-06-25 20:14 ` Robert Jennings [this message]
2008-06-25 20:14 ` [PATCH 02/18 v2] powerpc: Split processor entitlement retrieval and gathering to helper routines Robert Jennings
2008-06-25 20:14 ` [PATCH 03/18 v2] powerpc: Add memory entitlement capabilities to /proc/ppc64/lparcfg Robert Jennings
2008-06-25 20:15 ` [PATCH 04/18 v2] powerpc: Split retrieval of processor entitlement data into a helper routine Robert Jennings
2008-06-25 20:15 ` [PATCH 05/18 v2] powerpc: Enable CMO feature during platform setup Robert Jennings
2008-06-25 20:15 ` [PATCH 06/18 v2] powerpc: Utilities to set firmware page state Robert Jennings
2008-06-25 20:16 ` [PATCH 07/18 v2] powerpc: Add collaborative memory manager Robert Jennings
2008-06-25 20:17 ` [PATCH 08/18 v2] powerpc: Do not probe PCI buses or eBus devices if CMO is enabled Robert Jennings
2008-06-30 4:32 ` Paul Mackerras
2008-06-30 21:56 ` Brian King
2008-06-25 20:17 ` [PATCH 09/18 v2] powerpc: Add CMO paging statistics Robert Jennings
2008-06-25 20:17 ` [PATCH 10/18 v2] powerpc: iommu enablement for CMO Robert Jennings
2008-06-25 20:18 ` [PATCH 11/18 v2] powerpc: vio bus support " Robert Jennings
2008-06-25 20:18 ` [PATCH 12/18 v2] powerpc: Verify CMO memory entitlement updates with virtual I/O Robert Jennings
2008-06-25 20:18 ` [PATCH 13/18 v2] powerpc: hvc enablement for CMO Robert Jennings
2008-06-25 20:18 ` [PATCH 14/18 v2] powerpc: hvcs " Robert Jennings
2008-06-25 20:19 ` [PATCH 15/18 v2] ibmveth: Automatically enable larger rx buffer pools for larger mtu Robert Jennings
2008-06-25 20:19 ` [PATCH 16/18 v2] ibmveth: enable driver for CMO Robert Jennings
2008-06-25 20:19 ` [PATCH 17/18 v2] ibmvscsi: driver enablement " Robert Jennings
2008-06-25 20:19 ` [PATCH 18/18 v2] powerpc: Update arch vector to indicate support " Robert Jennings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080625201417.GC17020@linux.vnet.ibm.com \
--to=rcj@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=ddarring@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).