linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart()
@ 2008-06-26  9:48 Laurent Pinchart
  2008-06-26 13:56 ` Vitaly Bordug
  2008-07-04 12:25 ` Jeff Garzik
  0 siblings, 2 replies; 3+ messages in thread
From: Laurent Pinchart @ 2008-06-26  9:48 UTC (permalink / raw)
  To: linuxppc-dev, netdev; +Cc: Matvejchikov Ilya, vbordug

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

The restart() function is called when the link state changes and resets
multicast and promiscuous settings. This patch restores those settings at the
end of restart().

Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
---
 drivers/net/fs_enet/mac-fcc.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c
index e363211..849afbe 100644
--- a/drivers/net/fs_enet/mac-fcc.c
+++ b/drivers/net/fs_enet/mac-fcc.c
@@ -463,6 +463,9 @@ static void restart(struct net_device *dev)
 	else
 		C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
 
+	/* Restore multicast and promiscuous settings */
+	set_multicast_list(dev);
+
 	S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);
 }
 
-- 
1.5.0

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussee de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart()
  2008-06-26  9:48 [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart() Laurent Pinchart
@ 2008-06-26 13:56 ` Vitaly Bordug
  2008-07-04 12:25 ` Jeff Garzik
  1 sibling, 0 replies; 3+ messages in thread
From: Vitaly Bordug @ 2008-06-26 13:56 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linuxppc-dev, Matvejchikov Ilya, netdev

On Thu, 26 Jun 2008 11:48:22 +0200
Laurent Pinchart <laurentp@cse-semaphore.com> wrote:

> The restart() function is called when the link state changes and resets
> multicast and promiscuous settings. This patch restores those settings at the
> end of restart().
> 
> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
Acked-by: Vitaly Bordug <vitb@kernel.crashing.org>



-- 
Sincerely, 
Vitaly

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart()
  2008-06-26  9:48 [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart() Laurent Pinchart
  2008-06-26 13:56 ` Vitaly Bordug
@ 2008-07-04 12:25 ` Jeff Garzik
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-07-04 12:25 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linuxppc-dev, Matvejchikov Ilya, vbordug, netdev

Laurent Pinchart wrote:
> The restart() function is called when the link state changes and resets
> multicast and promiscuous settings. This patch restores those settings at the
> end of restart().
> 
> Signed-off-by: Laurent Pinchart <laurentp@cse-semaphore.com>
> ---
>  drivers/net/fs_enet/mac-fcc.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c
> index e363211..849afbe 100644
> --- a/drivers/net/fs_enet/mac-fcc.c
> +++ b/drivers/net/fs_enet/mac-fcc.c
> @@ -463,6 +463,9 @@ static void restart(struct net_device *dev)
>  	else
>  		C32(fccp, fcc_fpsmr, FCC_PSMR_FDE | FCC_PSMR_LPB);
>  
> +	/* Restore multicast and promiscuous settings */
> +	set_multicast_list(dev);
> +
>  	S32(fccp, fcc_gfmr, FCC_GFMR_ENR | FCC_GFMR_ENT);

applied 2.6.26

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-07-04 12:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-26  9:48 [PATCHv2] fs_enet: restore promiscuous and multicast settings in restart() Laurent Pinchart
2008-06-26 13:56 ` Vitaly Bordug
2008-07-04 12:25 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).