From: Grant Likely <grant.likely@secretlab.ca>
To: John Rigby <jrigby@freescale.com>, galak@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 6/6] MPC5121 Hide pci bridge
Date: Sat, 28 Jun 2008 23:42:07 -0600 [thread overview]
Message-ID: <20080629054207.GE13876@secretlab.ca> (raw)
In-Reply-To: <1213981119-1979-7-git-send-email-jrigby@freescale.com>
On Fri, Jun 20, 2008 at 10:58:39AM -0600, John Rigby wrote:
> The class of the MPC5121 pci host bridge is PCI_CLASS_BRIDGE_OTHER
> while other freescale host bridges have class set to
> PCI_CLASS_PROCESSOR_POWERPC.
>
> This patch makes fixup_hide_host_resource_fsl match
> PCI_CLASS_BRIDGE_OTHER in addition to PCI_CLASS_PROCESSOR_POWERPC.
>
> Signed-off-by: John Rigby <jrigby@freescale.com>
This looks right to me, but I'm not really qualified to say if it is
correct or not (limited PCI experience). I don't know who needs to look
at it. Kumar perhaps?
Cheers,
g.
> ---
> arch/powerpc/kernel/pci_32.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/pci_32.c b/arch/powerpc/kernel/pci_32.c
> index 88db4ff..3d33935 100644
> --- a/arch/powerpc/kernel/pci_32.c
> +++ b/arch/powerpc/kernel/pci_32.c
> @@ -54,11 +54,12 @@ LIST_HEAD(hose_list);
> static int pci_bus_count;
>
> static void
> -fixup_hide_host_resource_fsl(struct pci_dev* dev)
> +fixup_hide_host_resource_fsl(struct pci_dev *dev)
> {
> int i, class = dev->class >> 8;
>
> - if ((class == PCI_CLASS_PROCESSOR_POWERPC) &&
> + if ((class == PCI_CLASS_PROCESSOR_POWERPC
> + || class == PCI_CLASS_BRIDGE_OTHER) &&
> (dev->hdr_type == PCI_HEADER_TYPE_NORMAL) &&
> (dev->bus->parent == NULL)) {
> for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
> --
> 1.5.6.rc0.46.gd2b3
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2008-06-29 5:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 16:58 [PATCH 0/6] MPC5121 Updates John Rigby
[not found] ` <1213981119-1979-2-git-send-email-jrigby@freescale.com>
2008-06-20 16:58 ` [PATCH 2/6] MPC5121 clock driver John Rigby
2008-06-20 16:58 ` [PATCH 3/6] MPC5121 Add generic board support John Rigby
2008-06-20 16:58 ` [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support John Rigby
2008-06-20 16:58 ` [PATCH 5/6] MPC5121 Add PCI support John Rigby
2008-06-20 16:58 ` [PATCH 6/6] MPC5121 Hide pci bridge John Rigby
2008-06-29 5:42 ` Grant Likely [this message]
2008-06-20 22:03 ` [PATCH 5/6] MPC5121 Add PCI support Kumar Gala
2008-06-20 22:17 ` Scott Wood
2008-06-29 5:38 ` Grant Likely
2008-06-30 3:59 ` John Rigby
2008-06-29 5:36 ` [PATCH 4/6] MPC5121 Add MPC5121ADS cpld support Grant Likely
2008-06-30 4:01 ` John Rigby
2008-06-29 5:30 ` [PATCH 3/6] MPC5121 Add generic board support Grant Likely
2008-06-21 4:39 ` [PATCH 2/6] MPC5121 clock driver Stephen Rothwell
2008-06-29 5:21 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080629054207.GE13876@secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=galak@kernel.crashing.org \
--cc=jrigby@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).