From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 30 Jun 2008 14:15:25 +1000 From: David Gibson To: Kumar Gala Subject: Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards Message-ID: <20080630041525.GD24012@yookeroo.seuss> References: <48654D6D.1090309@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: Scott Wood , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote: > Added DMA nodes for the elo/elo-plus DMA engines. > > Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that > its the same as all the other boards. > > Signed-off-by: Kumar Gala [snip] > diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts b/arch/powerpc/boot/dts/asp834x-redboot.dts > index 972cf78..8b1bb0e 100644 > --- a/arch/powerpc/boot/dts/asp834x-redboot.dts > +++ b/arch/powerpc/boot/dts/asp834x-redboot.dts > @@ -118,6 +118,41 @@ > mode = "cpu"; > }; > > + dma@82a8 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "fsl,mpc8347-dma", "fsl,elo-dma"; > + reg = <0x82a8 4>; > + ranges = <0 0x8100 0x1a8>; > + interrupt-parent = <&ipic>; > + interrupts = <71 8>; > + cell-index = <0>; What's the cell-index in these nodes used to index? Given the confusion there's been about the proper use of this property, a comment indicating which shared registers this is used to index is probably a good idea. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson