From: John Linn <john.linn@xilinx.com>
To: linuxppc-dev@ozlabs.org, grant.likely@secretlab.ca,
paulus@samba.org, benh@kernel.crashing.org, dwg@au1.ibm.com,
jwboyer@linux.vnet.ibm.com, stephen.neuendorffer@xilinx.com
Cc: John Linn <john.linn@xilinx.com>
Subject: [PATCH] powerpc: legacy_serial: reg-offset & shift aren't used
Date: Tue, 1 Jul 2008 09:31:54 -0700 [thread overview]
Message-ID: <20080701163159.8B56512C8077@mail203-va3.bigfish.com> (raw)
The legacy serial driver does not work with an 8250
type UART that uses reg-offset and reg-shift. This
change updates the driver so it doesn't find the UART
when those properties are present on the UART in the
device tree for soc devices.
Signed-off-by: John Linn <john.linn@xilinx.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
---
arch/powerpc/kernel/legacy_serial.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
index 61dd174..b43235f 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -136,6 +136,11 @@ static int __init add_legacy_soc_port(struct device_node *np,
if (of_get_property(np, "clock-frequency", NULL) == NULL)
return -1;
+ /* if reg-shift and offset, don't try to use it */
+ if ((of_get_property(np, "reg-shift", NULL) != NULL) &&
+ (of_get_property(np, "reg-offset", NULL) != NULL))
+ return -1;
+
/* if rtas uses this device, don't try to use it as well */
if (of_get_property(np, "used-by-rtas", NULL) != NULL)
return -1;
--
1.5.2.1
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
next reply other threads:[~2008-07-01 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 16:31 John Linn [this message]
[not found] <12149299143952-git-send-email-john.linn@xilinx.com>
2008-07-01 16:48 ` [PATCH] powerpc: legacy_serial: reg-offset & shift aren't used Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B6150062A2DB4@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-07-01 16:52 ` John Linn
2008-07-01 17:06 ` Grant Likely
2008-07-01 17:07 ` John Linn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080701163159.8B56512C8077@mail203-va3.bigfish.com \
--to=john.linn@xilinx.com \
--cc=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=grant.likely@secretlab.ca \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=stephen.neuendorffer@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox