From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from IE1EHSOBE002.bigfish.com (outbound-dub.frontbridge.com [213.199.154.16]) by ozlabs.org (Postfix) with ESMTP id 718A8DDE0A for ; Wed, 2 Jul 2008 02:52:28 +1000 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Subject: RE: [PATCH] powerpc: legacy_serial: reg-offset & shift aren't used Date: Tue, 1 Jul 2008 10:52:20 -0600 In-Reply-To: <977C41F842E66D4CB2E41332313B6150062A2DB4@XSJ-EXCHVS1.xlnx.xilinx.com> References: <12149299143952-git-send-email-john.linn@xilinx.com> <977C41F842E66D4CB2E41332313B6150062A2DB4@XSJ-EXCHVS1.xlnx.xilinx.com> From: John Linn To: "Stephen Neuendorffer" , , , , , , Message-ID: <20080701165222.991255E0054@mail197-dub.bigfish.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , It could be "||" but I didn't know if there were cases where that wouldn't be true. I don't know that code that well so I was being conservative and maybe shouldn't be. = Our specific case works fine with "&&" since we have both in the device tree. = -- John -----Original Message----- From: Stephen Neuendorffer = Sent: Tuesday, July 01, 2008 10:48 AM To: John Linn; linuxppc-dev@ozlabs.org; grant.likely@secretlab.ca; paulus@samba.org; benh@kernel.crashing.org; dwg@au1.ibm.com; jwboyer@linux.vnet.ibm.com Subject: RE: [PATCH] powerpc: legacy_serial: reg-offset & shift aren't used > -----Original Message----- > From: John Linn [mailto:john.linn@xilinx.com] > Sent: Tuesday, July 01, 2008 9:32 AM > To: linuxppc-dev@ozlabs.org; grant.likely@secretlab.ca; paulus@samba.org; benh@kernel.crashing.org; > dwg@au1.ibm.com; jwboyer@linux.vnet.ibm.com; Stephen Neuendorffer > Cc: John Linn > Subject: [PATCH] powerpc: legacy_serial: reg-offset & shift aren't used > = > The legacy serial driver does not work with an 8250 > type UART that uses reg-offset and reg-shift. This > change updates the driver so it doesn't find the UART > when those properties are present on the UART in the > device tree for soc devices. > = > Signed-off-by: John Linn > Acked-by: Grant Likely > --- > = > arch/powerpc/kernel/legacy_serial.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > = > diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c > index 61dd174..b43235f 100644 > --- a/arch/powerpc/kernel/legacy_serial.c > +++ b/arch/powerpc/kernel/legacy_serial.c > @@ -136,6 +136,11 @@ static int __init add_legacy_soc_port(struct device_node *np, > if (of_get_property(np, "clock-frequency", NULL) =3D=3D NULL) > return -1; > = > + /* if reg-shift and offset, don't try to use it */ > + if ((of_get_property(np, "reg-shift", NULL) !=3D NULL) && > + (of_get_property(np, "reg-offset", NULL) !=3D NULL)) > + return -1; Um, shouldn't this be || ? > + > /* if rtas uses this device, don't try to use it as well */ > if (of_get_property(np, "used-by-rtas", NULL) !=3D NULL) > return -1; > -- > 1.5.2.1 > = This email and any attachments are intended for the sole use of the named r= ecipient(s) and contain(s) confidential information that may be proprietary= , privileged or copyrighted under applicable law. If you are not the intend= ed recipient, do not read, copy, or forward this email message or any attac= hments. Delete this email message and any attachments immediately.